Repository navigation
Fix stale FFmpeg plugin DLL reference in test project - #1997
Merged
Merged
Conversation
test/OpenCvSharp.Tests.csproj still referenced opencv_videoio_ffmpeg4130_64.dll, the plugin filename from the OpenCV 4.13.0 line the repo used before the 5.x migration. OpenCV 5.0.0 ships opencv_videoio_ffmpeg500_64.dll (see the runtime nupkg csproj, which was already updated), so the stale filename in the test csproj no longer matches what the native CMake build copies in, and the FFmpeg plugin was never copied to the test output directory at all.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test project configuration was updated to reference a different FFmpeg videoio native DLL version, changing the file copied to the output directory from opencv_videoio_ffmpeg4130_64.dll to opencv_videoio_ffmpeg500_64.dll. ChangesFFmpeg DLL Reference Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hundong2
pushed a commit
to hundong2/opencvsharp
that referenced
this pull request
Jul 4, 2026
…mat#1997) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/OpenCvSharp.Tests.csprojstill referencedopencv_videoio_ffmpeg4130_64.dll, the plugin filename from the OpenCV 4.13.0 line the repo used before the 5.x migration.opencv_videoio_ffmpeg500_64.dll(already reflected correctly inpackaging/nuget/OpenCvSharp5.runtime.win.csproj, and computed dynamically as500bysrc/OpenCvSharpExtern/CMakeLists.txt'sOPENCV_VER_STR).<None Update="...">filename no longer matched what the CMake build actually copies into the test project directory, the FFmpeg plugin DLL was never copied into the test output directory at all.Test plan
OpenCvSharp.Testsand confirmedopencv_videoio_ffmpeg500_64.dllis now copied tobin/Debug/net10.0/VideoCaptureTest/VideoWriterTestpass locally (no regressions)Summary by CodeRabbit