Skip to content

Fix stale FFmpeg plugin DLL reference in test project - #1997

Merged
shimat merged 1 commit into
mainfrom
fix/stale-ffmpeg-dll-version-in-tests
Jul 3, 2026
Merged

shimat merged 1 commit into
mainfrom
fix/stale-ffmpeg-dll-version-in-tests

Conversation

@shimat

@shimat shimat commented Jul 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • test/OpenCvSharp.Tests.csproj still referenced opencv_videoio_ffmpeg4130_64.dll, the plugin filename from the OpenCV 4.13.0 line the repo used before the 5.x migration.
  • OpenCV 5.0.0 ships opencv_videoio_ffmpeg500_64.dll (already reflected correctly in packaging/nuget/OpenCvSharp5.runtime.win.csproj, and computed dynamically as 500 by src/OpenCvSharpExtern/CMakeLists.txt's OPENCV_VER_STR).
  • Because the test csproj's <None Update="..."> filename no longer matched what the CMake build actually copies into the test project directory, the FFmpeg plugin DLL was never copied into the test output directory at all.

Test plan

  • Rebuilt OpenCvSharp.Tests and confirmed opencv_videoio_ffmpeg500_64.dll is now copied to bin/Debug/net10.0/
  • VideoCaptureTest / VideoWriterTest pass locally (no regressions)

Summary by CodeRabbit

  • Tests
    • Updated the test project to include the newer FFmpeg native DLL in output copies, keeping test runs aligned with the latest video I/O runtime.

test/OpenCvSharp.Tests.csproj still referenced
opencv_videoio_ffmpeg4130_64.dll, the plugin filename from the OpenCV
4.13.0 line the repo used before the 5.x migration. OpenCV 5.0.0 ships
opencv_videoio_ffmpeg500_64.dll (see the runtime nupkg csproj, which
was already updated), so the stale filename in the test csproj no
longer matches what the native CMake build copies in, and the FFmpeg
plugin was never copied to the test output directory at all.
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 765a0986-445b-40ef-8cae-146932ef9098

📥 Commits

Reviewing files that changed from the base of the PR and between 460d7cc and c53dd49.

📒 Files selected for processing (1)
  • test/OpenCvSharp.Tests/OpenCvSharp.Tests.csproj

📝 Walkthrough

Walkthrough

The test project configuration was updated to reference a different FFmpeg videoio native DLL version, changing the file copied to the output directory from opencv_videoio_ffmpeg4130_64.dll to opencv_videoio_ffmpeg500_64.dll.

Changes

FFmpeg DLL Reference Update

Layer / File(s) Summary
Update FFmpeg videoio DLL reference
test/OpenCvSharp.Tests/OpenCvSharp.Tests.csproj
Changed the None item update entry so the FFmpeg videoio DLL copied to output is opencv_videoio_ffmpeg500_64.dll instead of opencv_videoio_ffmpeg4130_64.dll, with CopyToOutputDirectory remaining PreserveNewest.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • shimat/opencvsharp#1883: Both PRs adjust how the FFmpeg videoio native DLL is referenced/copied in build tooling.
  • shimat/opencvsharp#1954: Both PRs modify how the Windows FFmpeg native DLL is included in project outputs across csproj files.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the stale FFmpeg plugin DLL reference in the test project.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/stale-ffmpeg-dll-version-in-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shimat shimat self-assigned this Jul 3, 2026
@shimat
shimat merged commit e08eb59 into main Jul 3, 2026
14 checks passed
@shimat
shimat deleted the fix/stale-ffmpeg-dll-version-in-tests branch July 3, 2026 12:59
hundong2 pushed a commit to hundong2/opencvsharp that referenced this pull request Jul 4, 2026
…mat#1997)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shimat shimat added the bug Confirmed defect in OpenCvSharp label Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Confirmed defect in OpenCvSharp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant