Repository navigation
Fix Windows NuGet pack: FFmpeg DLL path moved to vc18 - #1954
Merged
Merged
Conversation
The Windows CI generator was bumped to "Visual Studio 18 2026", so OpenCV now installs to opencv_artifacts/x64/vc18/ instead of vc17/. The runtime.win package still referenced the vc17 path for opencv_videoio_ffmpeg4130_64.dll, causing "Pack NuGet packages" to fail with "Could not find a part of the path '...\opencv_artifacts\x64\vc17\bin'". Update the path to vc18 to match the install layout. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates the Windows runtime NuGet package entry for ChangesWindows runtime package path update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jun 29, 2026
2 tasks done
This was referenced Jul 6, 2026
This was referenced Jul 25, 2026
This was referenced Aug 10, 2026
This was referenced Sep 9, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Windows CI
buildjob fails at the Pack NuGet packages step:Cause
windows.ymlwas updated to theVisual Studio 18 2026generator (commitsdc77c4d9,bb2da29c). OpenCV's install layout is toolset-versioned, so it now installs underopencv_artifacts/x64/**vc18**/instead ofvc17/. Confirmed from the CI build log:OpenCvSharp4.runtime.win.csprojstill referenced the stalevc17path for the FFmpeg DLL, so pack failed.Fix
Update the FFmpeg DLL path in
OpenCvSharp4.runtime.win.csprojfromvc17→vc18to match the new install layout.Scope notes:
ReleaseMakerkeepvc17— those use a separately distributed prebuilt OpenCV (opencv_world490, built with VS 2022), unrelated to this from-source build.a3fb3bf7) and already passes.videoio, so it does not ship the FFmpeg DLL.🤖 Generated with Claude Code
Summary by CodeRabbit