Update Readme to reflect recommended GPG key usage #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
Reduce errors produced in terminal from debian package installations by testing for existence of symlink prior to executing unlink
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories. This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
* Update README.md to add mirror I added `mirror.mwt.me` as a possible repo option. I tried to keep this stylistically consistent with the rest of the document. I also offloaded the GPG key download to keys.openpgp.org. This allows this step to work even if PackageCloud is out of bandwidth. It also has the advantage of putting the key id in the README and does not require users to trust me. * undo use of openpgp.org * Mention AppImage and Flatpak
* add support for gnome console * Delete configurationCache.log * Update linux.ts * fix cap of gnome * support new GNOME Text Editor * support GNOME builder
* feat: support detecting VsCode in WSL * reformat file Co-authored-by: Brendan Forster <github@brendanforster.com>
…ors (shiftkey#711) * add LXTerminal to supported terminals * add geany to supported editors list * Update linux.ts * add mousepad to supported editors * lint changed files Co-authored-by: Brendan Forster <github@brendanforster.com>
* add armv7l support to scripts * lint fix new files Co-authored-by: Brendan Forster <github@brendanforster.com>
shiftkey#706) Bumps [electron-packager](https://github.com/electron/electron-packager) from 15.2.0 to 15.5.1. - [Release notes](https://github.com/electron/electron-packager/releases) - [Changelog](https://github.com/electron/electron-packager/blob/main/NEWS.md) - [Commits](electron/packager@v15.2.0...v15.5.1) --- updated-dependencies: - dependency-name: electron-packager dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…shiftkey#505 shiftkey#526 shiftkey#608 shiftkey#629 shiftkey#655 shiftkey#695 shiftkey#729) Bumps [electron-builder](https://github.com/electron-userland/electron-builder) from 22.9.1 to 23.1.0. - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/CHANGELOG.md) - [Commits](electron-userland/electron-builder@v22.9.1...v23.1.0) --- updated-dependencies: - dependency-name: electron-builder dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [electron-packager](https://github.com/electron/electron-packager) from 15.5.1 to 16.0.0. - [Release notes](https://github.com/electron/electron-packager/releases) - [Changelog](https://github.com/electron/electron-packager/blob/main/NEWS.md) - [Commits](electron/packager@v15.5.1...v16.0.0) --- updated-dependencies: - dependency-name: electron-packager dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [electron-builder](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/electron-builder) from 23.3.3 to 23.6.0. - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/v23.6.0/packages/electron-builder) --- updated-dependencies: - dependency-name: electron-builder dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4.1.3 to 4.2.0. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v4.1.3...v4.2.0) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Any gpg key in /etc/apt/trusted.gpg.d/ directory is implicitly trusted by apt for all packages. The recommended way is to explicitly specify gpg for each repo, ensuring this gpg key will only be used for packages from this repo.
sarim
changed the title
sarim
changed the title
shiftkey
force-pushed
the
linux
branch
2 times, most recently
from
70e66f5 to
974d938
Compare
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Any gpg key in /etc/apt/trusted.gpg.d/ directory is implicitly trusted by apt for all packages. The recommended way is to explicitly specify gpg for each repo, ensuring this gpg key will only be used for packages from this repo.
This PR updates readme to reflect recommended GPG key usage. Please read this askubuntu answer to learn more about gpg key usage in apt: https://askubuntu.com/a/1307181/225795
This PR also adds another line of instruction to get GPG key from packagecloud.
Note
While I thoroughly checked it in ubuntu, and can confirm that it now follows recommendation, the instructions for rpms are problematic.