Theme Scrollbars #240
Merged
Theme Scrollbars #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated scrollbars to match windows webkit styling for both light and dark mode
4 tasks
Separating linux from win32 reference, in case we want to adjust for the future and not impact the other
Author
|
FYI - there's an upstream issue where the scrollbars very hard to see on the dark theme. I posted PR 9416 to adjust the coloring. |
Owner
|
@jfgordon2 if that gets approved and merged you can pull those changes into this branch so it's available for the next Linux release |
Author
You got it 👍 |
Owner
|
@jfgordon2 looks like your PR was merged - congratulations! Feel free to pull those changes into this branch, and I think this is good to land aside from the dependency on the mixins that are planned to be removed in #237 |
Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
Author
|
@shiftkey Thank you! It's now updated |
shiftkey
approved these changes
Apr 2, 2020
Owner
shiftkey
left a comment
shiftkey
left a comment
There was a problem hiding this comment.
I'm going to merge this in now and address #237 later on. Thanks for the quick PR on this @jfgordon2, as well as upstreaming the tweak to the colours!
shiftkey
pushed a commit
that referenced
this pull request
Apr 2, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
2 tasks
shiftkey
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 16, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 16, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 16, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 17, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 23, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 29, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
May 1, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
May 1, 2020
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jan 29, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Feb 26, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Feb 26, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Feb 26, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Mar 2, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 4, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 7, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 7, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Apr 7, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
theofficialgman
pushed a commit
to theofficialgman/desktop
that referenced
this pull request
Jun 4, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jun 5, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jun 5, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
shiftkey
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236
Description
Updated scrollbars to match windows webkit styling for both light and dark mode
Screenshots
Release notes
Notes: Matched webkit-scrollbar styling from windows to linux for consistency and to fix scrollbars in dark mode