refactor(ui): use new DataTable in admin #4929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizhf42
force-pushed
the
refactor/admin-data-table
branch
from
58b6c9e to
11610b7
Compare
luizhf42
force-pushed
the
refactor/admin-data-table
branch
5 times, most recently
from
ec9d09d to
e867c72
Compare
luizhf42
force-pushed
the
refactor/admin-data-table
branch
from
e867c72 to
cc6d774
Compare
luizhf42
force-pushed
the
refactor/admin-data-table
branch
from
cc6d774 to
64fe96f
Compare
luizhf42
force-pushed
the
refactor/admin-data-table
branch
from
ed0b78b to
bfe1904
Compare
* refactor admin table-based components to use `src`'s data table * adjust `DataTable.vue` to match with admin's UI * update tests' snapshots
* remove old code that caused an infinite loop when the fetch return was empty
* removed duplicated try/catch blocks in the table-based components * reduced code duplication * removed redundant `loading` value changes
* rename the methods to `fetchX` * remove unnecessary params * add async/await keywords in some missing places
* call the `handleError` util in catch blocks that missed it
luizhf42
force-pushed
the
refactor/admin-data-table
branch
from
bfe1904 to
ad58e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the old admin's
DataTablecomponent, now using the recently refactored component. Other improvements and fixes were also made in the affected components, and snapshots have been updated accordingly.DataTablecode and testssrc