Skip to content

refactor(ui): refactor DataTable component #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gustavosbarreto merged 1 commit into from
Jun 17, 2025
Merged

refactor(ui): refactor DataTable component #4890

gustavosbarreto merged 1 commit into from
Jun 17, 2025

Conversation

@luizhf42
Copy link
Member

@luizhf42 luizhf42 commented Jun 5, 2025 •
edited
Loading

This PR refactors the DataTable.vue component:

  • Improves its logic, making it simpler
  • Fixes some pagination/navigation-related bugs
  • Refactors the components' props, removing unused props and improving typing
  • Replaces confusing emits with Vue's cleaner defineModel
  • Improves sorting logics in tables using that feature
  • Updates the tests and snapshots

@luizhf42 luizhf42 added this to the v0.19.x milestone Jun 5, 2025
@luizhf42 luizhf42 self-assigned this Jun 5, 2025
@luizhf42 luizhf42 added area/ui status/work-in-progress javascript Pull requests that update Javascript code kind/refactor labels Jun 5, 2025
@luizhf42 luizhf42 force-pushed the refactor/data-table branch 4 times, most recently from 8e2e638 to e75f87d Compare June 5, 2025 20:26
@luizhf42 luizhf42 marked this pull request as ready for review June 5, 2025 20:26
@luizhf42 luizhf42 requested a review from a team as a code owner June 5, 2025 20:26
@luizhf42 luizhf42 force-pushed the refactor/data-table branch from e75f87d to 0bbeeaf Compare June 5, 2025 20:30
@luizhf42 luizhf42 force-pushed the refactor/data-table branch 3 times, most recently from 4782f51 to 048aca8 Compare June 10, 2025 20:40
@luizhf42
refactor(ui): refactor DataTable component
1b4fa7c 
- refactor component props
- replace emits with `defineModel`
- fix pagination bugs
- improve sorting logic
- update components that use `DataTable`
- update snapshots and tests
@luizhf42 luizhf42 force-pushed the refactor/data-table branch from 048aca8 to 1b4fa7c Compare June 16, 2025 14:20
@gustavosbarreto gustavosbarreto merged commit a3baae1 into master Jun 17, 2025
8 checks passed
@gustavosbarreto gustavosbarreto deleted the refactor/data-table branch June 17, 2025 14:58
@luizhf42 luizhf42 mentioned this pull request Jun 20, 2025
Merged
@luizhf42 luizhf42 mentioned this pull request Sep 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gustavosbarreto gustavosbarreto Awaiting requested review from gustavosbarreto

@luannmoreira luannmoreira Awaiting requested review from luannmoreira

Assignees

@luizhf42 luizhf42

Labels

area/ui javascript Pull requests that update Javascript code kind/refactor status/needs-review

Projects

None yet

Milestone

v0.19.x

Development

Successfully merging this pull request may close these issues.

3 participants

@luizhf42 @gustavosbarreto