Skip to content

refactor(ui): change Connector Add to Container Modal in empty Containers view #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavosbarreto merged 1 commit into from
Jun 5, 2025
Merged

refactor(ui): change Connector Add to Container Modal in empty Containers view #4889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions ui/src/views/Containers.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
type-message="container"
data-test="boxMessageDevice-component"
>
<template v-slot:container v-if="envVariables.hasConnector">
<ConnectorAdd @update="refresh" />
<template v-slot:container>
<ContainerAdd />
</template>
</BoxMessage>
</template>
Expand All @@ -47,12 +47,10 @@
import { computed, ref, onUnmounted } from "vue";
import { useRouter } from "vue-router";
import { useStore } from "../store";
import { envVariables } from "../envVariables";

Check warning on line 50 in ui/src/views/Containers.vue

View workflow job for this annotation

GitHub Actions / validate (ui) 

'envVariables' is defined but never used

Check warning on line 50 in ui/src/views/Containers.vue

View workflow job for this annotation

GitHub Actions / validate (ui) 

'envVariables' is defined but never used
import ConnectorAdd from "../components/Connector/ConnectorAdd.vue";
import Containers from "../components/Containers/Container.vue";
import TagSelector from "../components/Tags/TagSelector.vue";
import BoxMessage from "../components/Box/BoxMessage.vue";
import handleError from "@/utils/handleError";
import ContainerAdd from "../components/Containers/ContainerAdd.vue";
import useSnackbar from "@/helpers/snackbar";

Expand Down Expand Up @@ -90,24 +88,6 @@

const isContainerList = computed(() => router.currentRoute.value.name === "ContainerList");

const refresh = async () => {
loading.value = true;
setTimeout(() => {
try {
store.dispatch("container/fetch", {
page: store.getters["container/getPage"],
perPage: store.getters["container/getPerPage"],
filter: store.getters["container/getFilter"],
status: "",
committable: false,
});
} catch (error) {
handleError(error);
}
loading.value = false;
}, 10000);
};

onUnmounted(async () => {
await store.dispatch("container/setFilter", "");
});
Expand Down