refactor(ui): change Connector Add to Container Modal in empty Containers view #4889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced ConnectorAdd with ContainerAdd component unconditionally. Removed related refresh logic and ConnectorAdd import. Cleaned up unused error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the logic for displaying the container addition component in the Containers.vue view. Key changes include:
This refactor removes legacy connector logic, improves clarity, and reduces unused code.
Why:
The conditional rendering based on envVariables.hasConnector is no longer needed, and maintaining legacy ConnectorAdd logic created unnecessary complexity.
Impact:
Only affects the UI logic related to adding containers. No backend or data-fetching logic is impacted.