Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Fix font-family override in UITextDisplayer #7249

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix(UI): Fix font-family override in UITextDisplayer #7249

merged 2 commits into from
Sep 4, 2024

Commits on Sep 3, 2024

  1. fix(UI): Fix font-family override in UITextDisplayer 

    Font settings were applied to ".shaka-video-container *", all descendents of .shaka-video-container. This meant that the font setting inheritance intended in our UI text displayer was broken, because those descendents effectively had their own settings and didn't inherit them from their parents in the subtitle DOM hierarchy.  We fix this by breaking down the CSS and applying those font settings directly to the top level .shaka-video-container, to be inherited by any descendent without their own setting.
    @avelad
    avelad committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c8787db View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ui-text-displayer-font-family-override

    @avelad
    avelad committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e5fdf9e View commit details
    Browse the repository at this point in the history