fix(UI): Fix font-family override in UITextDisplayer #7249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Font settings were applied to ".shaka-video-container *", all descendents of .shaka-video-container. This meant that the font setting inheritance intended in our UI text displayer was broken, because those descendents effectively had their own settings and didn't inherit them from their parents in the subtitle DOM hierarchy. We fix this by breaking down the CSS and applying those font settings directly to the top level .shaka-video-container, to be inherited by any descendent without their own setting.
avelad
added
type: bug
|
This PR will probably require updating a lot of screenshots, I'll wait for the tests to pass to verify it... |
|
Incremental code coverage: No instrumented code was changed. |
theodab
approved these changes
Sep 4, 2024
avelad
added a commit
that referenced
this pull request
Sep 4, 2024
Font settings were applied to ".shaka-video-container *", all descendents of .shaka-video-container. This meant that the font setting inheritance intended in our UI text displayer was broken, because those descendents effectively had their own settings and didn't inherit them from their parents in the subtitle DOM hierarchy. We fix this by breaking down the CSS and applying those font settings directly to the top level .shaka-video-container, to be inherited by any descendent without their own setting.
avelad
added a commit
that referenced
this pull request
Sep 4, 2024
Font settings were applied to ".shaka-video-container *", all descendents of .shaka-video-container. This meant that the font setting inheritance intended in our UI text displayer was broken, because those descendents effectively had their own settings and didn't inherit them from their parents in the subtitle DOM hierarchy. We fix this by breaking down the CSS and applying those font settings directly to the top level .shaka-video-container, to be inherited by any descendent without their own setting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font settings were applied to ".shaka-video-container *", all descendents of .shaka-video-container. This meant that the font setting inheritance intended in our UI text displayer was broken, because those descendents effectively had their own settings and didn't inherit them from their parents in the subtitle DOM hierarchy. We fix this by breaking down the CSS and applying those font settings directly to the top level .shaka-video-container, to be inherited by any descendent without their own setting.