Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vtt with one digit hour #522

Merged
merged 5 commits into from
Sep 15, 2016
Merged

Fix vtt with one digit hour #522

merged 5 commits into from
Sep 15, 2016

Conversation

esteban-dosztal
Copy link
Contributor

@esteban-dosztal esteban-dosztal commented Sep 15, 2016 •
edited
Loading

Fixes #521

@esteban-dosztal esteban-dosztal mentioned this pull request Sep 15, 2016
Closed
joeyparrish
joeyparrish approved these changes Sep 15, 2016
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm going to run it through our buildbot.

@shaka-bot
Copy link
Collaborator

Testing in progress...

@shaka-bot
Copy link
Collaborator

Failure:

+ echo START-BUILD
START-BUILD
+ ./build/all.py
----- FILE  :  /var/lib/jenkins/jobs/Manual PR Test/workspace/test/media/vtt_text_parser_unit.js -----
Line 326, E:0110: Line too long (84 characters).
Found 1 errors, including 0 new errors, in 1 files (161 files OK).
Generating Closure dependencies...
Running Closure linter...
Build step 'Execute shell' marked build as failure

@joeyparrish
Copy link
Member

Please fix the linter errors and run ./build/all.py to verify locally. Let us know when you have updated the PR and I'll run it through the bot again.

@esteban-dosztal
Copy link
Contributor Author

esteban-dosztal commented Sep 15, 2016 •
edited
Loading

Sorry for that.
It's updated.
Thanks!

@shaka-bot
Copy link
Collaborator

Testing in progress...

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish
Copy link
Member

Thanks very much for your contribution!

@joeyparrish joeyparrish merged commit fed8429 into shaka-project:master Sep 15, 2016
joeyparrish pushed a commit that referenced this pull request Oct 19, 2016
@esteban-dosztal @joeyparrish
Fix vtt with one digit hour (#522)
52c0f52
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esteban-dosztal @shaka-bot @joeyparrish