Skip to content

Commit

Permalink
ci(i): Make change detector an independent workflow (sourcenetwork#2789)
Browse files Browse the repository at this point in the history
## Relevant issue(s)
Resolves sourcenetwork#2736

## Description
- Move change detection to a separate workflow to not block code
coverage upload to be dependent / blocked by it.
- More reasons in the issue (sourcenetwork#2736) on why we want this.

### Note will need to change required checks naming, will do it
pre-merge and after an approval.

## How has this been tested?
- Manually

Specify the platform(s) on which this was tested:
- WSL2
  • Loading branch information
shahzadlone authored Jun 28, 2024
1 parent 343ec38 commit 8437805
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 13 deletions.
50 changes: 50 additions & 0 deletions .github/workflows/check-data-format-changes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# Copyright 2024 Democratized Data Foundation
#
# Use of this software is governed by the Business Source License
# included in the file licenses/BSL.txt.
#
# As of the Change Date specified in that file, in accordance with
# the Business Source License, use of this software will be governed
# by the Apache License, Version 2.0, included in the file
# licenses/APL.txt.

name: Check Data Format Changes Workflow

on:
pull_request:
branches:
- master
- develop

push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+'
branches:
- master
- develop

jobs:
check-data-format-changes:
name: Check data format changes job

runs-on: ubuntu-latest

steps:

- name: Checkout code into the directory
uses: actions/checkout@v4

- name: Setup Go environment explicitly
uses: actions/setup-go@v5
with:
go-version-file: 'go.mod'
check-latest: true
cache: false

- name: Build dependencies
run: |
make deps:modules
make deps:test
- name: Run data format change detection tests
run: make test:changes
13 changes: 0 additions & 13 deletions .github/workflows/test-and-upload-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,51 +35,44 @@ jobs:
database-type: [badger-file, badger-memory]
mutation-type: [gql, collection-named, collection-save]
lens-type: [wasm-time]
detect-changes: [false]
database-encryption: [false]
include:
- os: ubuntu-latest
client-type: go
database-type: badger-memory
mutation-type: collection-save
lens-type: wasm-time
detect-changes: true
database-encryption: false
- os: ubuntu-latest
client-type: go
database-type: badger-memory
mutation-type: collection-save
lens-type: wasm-time
detect-changes: false
database-encryption: true
- os: macos-latest
client-type: go
database-type: badger-memory
mutation-type: collection-save
lens-type: wasm-time
detect-changes: false
database-encryption: false
## TODO: https://github.com/sourcenetwork/defradb/issues/2080
## Uncomment the lines below to Re-enable the windows build once this todo is resolved.
## - os: windows-latest
## client-type: go
## database-type: badger-memory
## mutation-type: collection-save
## detect-changes: false
## database-encryption: false
- os: ubuntu-latest
client-type: go
database-type: badger-memory
mutation-type: collection-save
lens-type: wazero
detect-changes: false
database-encryption: false
- os: ubuntu-latest
client-type: go
database-type: badger-memory
mutation-type: collection-save
lens-type: wasmer
detect-changes: false
database-encryption: false

runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -156,15 +149,9 @@ jobs:
make deps:test
- name: Run integration tests
if: ${{ !matrix.detect-changes }}
run: make test:coverage

- name: Run change detector tests
if: ${{ matrix.detect-changes }}
run: make test:changes

- name: Upload coverage artifact
if: ${{ !matrix.detect-changes }}
uses: actions/upload-artifact@v4
with:
# Make sure the name is always unique per job as artifacts are now immutable.
Expand Down

0 comments on commit 8437805

Please sign in to comment.