Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(i): Make change detector an independent workflow #2789

Merged

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #2736

Description

Note will need to change required checks naming, will do it pre-merge and after an approval.

How has this been tested?

  • Manually

Specify the platform(s) on which this was tested:

  • WSL2

@shahzadlone shahzadlone added the ci/build This is issue is about the build or CI system, and the administration of it. label Jun 27, 2024
@shahzadlone shahzadlone requested a review from a team June 27, 2024 22:37
@shahzadlone shahzadlone self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.90%. Comparing base (343ec38) to head (a630a3f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2789      +/-   ##
===========================================
+ Coverage    78.84%   78.90%   +0.06%     
===========================================
  Files          315      315              
  Lines        23835    23835              
===========================================
+ Hits         18792    18806      +14     
+ Misses        3669     3663       -6     
+ Partials      1374     1366       -8     
Flag Coverage Δ
all-tests 78.90% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343ec38...a630a3f. Read the comment docs.

Copy link
Member

@nasdf nasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a much better approach than including it in the test matrix.

@shahzadlone shahzadlone merged commit 8437805 into sourcenetwork:develop Jun 28, 2024
38 of 39 checks passed
@shahzadlone shahzadlone deleted the lone/ci/split-change-detection branch June 28, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split change detector action into a separate job, or a separate workflow completely
2 participants