Skip to content

Conversation

@ethanfowler
Copy link
Contributor

…at they can be resolved externally.

Proposed changes

Please explain the changes you made. Add pictures or videos to explain them better if appropriate.

Checklist

Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.

Tests

  • No tests required to be added. (For small changes that will be tested by CI/CD infrastructure).
  • Added/Modified automated and PhantomHand CI tests (if a new class is added (Python or C++), the interface of that class must be unit tested).
  • Manually tested in simulation (if simulation specific or no hardware required to test the functionality).
  • Manually tested on hardware (if hardware specific or related).

Documentation

  • No documentation required to be added.
  • Added documentation (For any new feature, explain what it does and how to use it. Write the documentation in a relevant space, e.g. Github, Confluence, etc).
  • Updated documentation (For changes to pre-existing features mentioned in the documentation).

@ethanfowler ethanfowler requested review from a team as code owners April 24, 2023 15:52
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #234 (c807d38) into noetic-devel (a3fdb07) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           noetic-devel     #234   +/-   ##
=============================================
  Coverage         33.90%   33.90%           
=============================================
  Files                16       16           
  Lines               879      879           
  Branches            577      577           
=============================================
  Hits                298      298           
  Misses              101      101           
  Partials            480      480           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ethanfowler ethanfowler merged commit a026508 into noetic-devel Apr 25, 2023
@ethanfowler ethanfowler deleted the F_#HE-570_fix_hand_finder_export branch April 25, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants