Remove wavread and wavwrite #81
Conversation
|
I think, we should leave it at Regarding the bit quantization: So you saved the BRIRs in 16 bit integer? Because 32 bit is the only supported floating point format *.wav supports, I think. I don't think, that the 16bit quantization had audible effects on the BRIRs. I dont' think, that is necessary to add 16bit integer to the function, either. I think we should keep the current copyright message. Strictly speaking, we would violate the MIT License, if we would just remove the copyright statement. Of course, I'm the copyright owner and I can do whatever I want with it, but maybe it's a good example how code from other sources can be integrated into the toolbox. In the end, if you're not very comfortable with it, you can also replace it by the copyright message of the toolbox. |
|
I agree and have updated the code accordingly. |
* master: Update copyright owner to SFS Toolbox Developers Update README for online documentation Remove wavread and wavwrite (#81) Return delay offset from delayline() (#82) New Handling of delayline and fractional delay (#50) Fix dos line endings Update comments for SSR BRS Update license in missing files Change license to MIT (#80) Make direction_vector() work with matrix => vector add modal weighting to time-domain nfchoa (#77) Fix comment of tapering_window() Add automatic scaling to loudspeaker weights for plotting (#78) Update comment of interpolation() Update NEWS Fix interpolation calling bug in interpolation_ir() Remove debugging parameter Fix normalization for 2D interpolation Further improvements to description of interpolation() Enhance description for interpolation() Conflicts: SFS_general/direction_vector.m
As
wavread()andwavwrite()will be removed in future Matlab versions I think it is ok to remove them from the Toolbox as well.wavread()was easy as it is just replaced byaudioread(). Forwavwrite()we have the problems of multichannel wav-files as we use it to save the BRS files. I copied thesavewavfile from the Binaural simulator and stored it assave_ssr_brs()for the moment.Maybe it is a better idea to store it also as
savewavunderSFS_general?I also switched the order of input arguments to be identical to
audiowrite().At the moment we can only save to 32bit. In prior experiments I saved the BRS files as 16bit, was this a bad idea or should we include that option as well to
save_ssr_brs()in order to save space as BRS files are normally quite large?At the moment I have the copyright statement from the original
savewavfile. Can we simply replace it by the SFS copyright statement or would you prefer to stay with the original one?After we agree on this questions I will clean up the code of the function.