Add automatic scaling to loudspeaker weights for plotting #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think its a good idea. In the context of WFS and the secondary source selection its also nice, as the active secondary source would be dark/black and the inactive are white. Maybe it's a good idea to use the maximum of the absolute value instead of the maximum. I don't know, why there should be any negative loudspeakers weights at the moment. Maybe someone decides to implement some ambisonics panning functions in the future, which may have negative weights. |
|
OK, I changed it and will merge it into the master. |
hagenw
added a commit
that referenced
this pull request
May 13, 2016
* master: Update license in missing files Change license to MIT (#80) Make direction_vector() work with matrix => vector add modal weighting to time-domain nfchoa (#77) Fix comment of tapering_window() Add automatic scaling to loudspeaker weights for plotting (#78) Update comment of interpolation() Conflicts: SFS_general/delayline.m
hagenw
added a commit
that referenced
this pull request
May 26, 2016
* master: Update copyright owner to SFS Toolbox Developers Update README for online documentation Remove wavread and wavwrite (#81) Return delay offset from delayline() (#82) New Handling of delayline and fractional delay (#50) Fix dos line endings Update comments for SSR BRS Update license in missing files Change license to MIT (#80) Make direction_vector() work with matrix => vector add modal weighting to time-domain nfchoa (#77) Fix comment of tapering_window() Add automatic scaling to loudspeaker weights for plotting (#78) Update comment of interpolation() Update NEWS Fix interpolation calling bug in interpolation_ir() Remove debugging parameter Fix normalization for 2D interpolation Further improvements to description of interpolation() Enhance description for interpolation() Conflicts: SFS_general/direction_vector.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 7b46fff we introduced a new weighting to the loudspeakers, which results in relatively low values (<<1) for standard setups. This is of course not a problem, but has a small effect on the plotting of real loudspeaker symbols as those are colored accordingly to the absolute weight of the loudspeaker.
Here is an example from the current master:
As you can see more or less all loudspeakers are white.
In this pull request I added an automatic scaling of the loudspeakers (that the maximum weight to 1) to the
draw_loudspeakerfunction, which results in this plot by executing the same commands as above.I'm not sure yet if this is the best solution for more complex cases, but I think it is better than before.