Skip to content

Code cleanup and warning fixes #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2015
Merged

Code cleanup and warning fixes #58

merged 2 commits into from
Feb 21, 2015

Conversation

zummenix
Copy link
Contributor

@zummenix
Fixed warnings.
e7eb606
@zummenix
Removed dummy parametr in type_id method.
36b7b61 
Closes servo#17
Now call like:
`let id = <CFBoolean as TCFType<_>>::type_id();`

[breaking-change]
@mbrubeck mbrubeck changed the title Patch Code cleanup and warning fixes Feb 18, 2015
brendanzab added a commit that referenced this pull request Feb 21, 2015
@brendanzab
Merge pull request #58 from zummenix/patch
c577bd6 
Code cleanup and warning fixes
@brendanzab brendanzab merged commit c577bd6 into servo:master Feb 21, 2015
@zummenix zummenix deleted the patch branch February 22, 2015 15:06
jdm pushed a commit that referenced this pull request Feb 1, 2018
@larsbergstrom
Merge pull request #58 from bjz/window_methods
6cff0d4 
Add lots of missing window methods
jdm pushed a commit that referenced this pull request Feb 1, 2018
Auto merge of #58 - sotaroikeda:upgleam, r=glennw
a135e6e 
Update gleam to v0.4

Fixes #57.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/io-surface-rs/58)
<!-- Reviewable:end -->
jdm pushed a commit that referenced this pull request Feb 1, 2018
Auto merge of #58 - algesten:font_path, r=jdm
7a267bc 
font_path may be null

Given PR #57, we can quite easily get `CTFontDescriptor` that returns `null` for the `font_path`.

In the default font chains I've seen at least two fonts that are part of the chains but we can't get the `font_path`. Interestingly the font names and family names are prefixed with a `.` as if to indicate they are internal:

      ".Apple Symbols Fallback",
      ".Noto Sans Universal",

This is a breaking change, so may be undesirable, but I think it requires discussion.

Here's the full fallback list for `Menlo` and language `en`.

```
      "Monaco",
      ".Apple Symbols Fallback",
      "Lucida Grande",
      "Courier New",
      "Ayuthaya",
      "Kailasa",
      "PingFang SC",
      "PingFang TC",
      "Hiragino Sans",
      "Hiragino Sans GB",
      "Apple SD Gothic Neo",
      "PingFang HK",
      "Kohinoor Bangla",
      "Kohinoor Devanagari",
      "Gujarati Sangam MN",
      "Gurmukhi MN",
      "Kannada Sangam MN",
      "Khmer Sangam MN",
      "Lao Sangam MN",
      "Malayalam Sangam MN",
      "Myanmar Sangam MN",
      "Oriya Sangam MN",
      "Sinhala Sangam MN",
      "Tamil Sangam MN",
      "Kohinoor Telugu",
      "Mshtakan",
      "Euphemia UCAS",
      "Plantagenet Cherokee",
      ".Noto Sans Universal",
      "Apple Color Emoji"
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/58)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specifying a type to use for parameter-less "static" default methods in a trait
2 participants
@zummenix @brendanzab