Use libc from crates.io #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Use faithful BOOL type in bindings
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Fix all the things <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/57) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Update gleam to v0.4 Fixes #57. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/io-surface-rs/58) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
CTFontCopyDefaultCascadeListForLanguages This adds `cascade_list_for_languages` to get apple's built in font fallbacks chains per font/language list combo. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/57) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
font_path may be null Given PR #57, we can quite easily get `CTFontDescriptor` that returns `null` for the `font_path`. In the default font chains I've seen at least two fonts that are part of the chains but we can't get the `font_path`. Interestingly the font names and family names are prefixed with a `.` as if to indicate they are internal: ".Apple Symbols Fallback", ".Noto Sans Universal", This is a breaking change, so may be undesirable, but I think it requires discussion. Here's the full fallback list for `Menlo` and language `en`. ``` "Monaco", ".Apple Symbols Fallback", "Lucida Grande", "Courier New", "Ayuthaya", "Kailasa", "PingFang SC", "PingFang TC", "Hiragino Sans", "Hiragino Sans GB", "Apple SD Gothic Neo", "PingFang HK", "Kohinoor Bangla", "Kohinoor Devanagari", "Gujarati Sangam MN", "Gurmukhi MN", "Kannada Sangam MN", "Khmer Sangam MN", "Lao Sangam MN", "Malayalam Sangam MN", "Myanmar Sangam MN", "Oriya Sangam MN", "Sinhala Sangam MN", "Tamil Sangam MN", "Kohinoor Telugu", "Mshtakan", "Euphemia UCAS", "Plantagenet Cherokee", ".Noto Sans Universal", "Apple Color Emoji" ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/58) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Add a lion feature for 10.7 compatibility This allows #57 to build on OS X 10.7, if built with the "lion" feature. This is modeled on the "elcapitan" feature in core-graphics-rs. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/61) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to make glutin compile on os/x.