Adding Cache-Control header to assets and media files

[guillaumebriday]

I added the Cache-Control header to assets and media files.

Most of applications use the cache-busting pattern so to increase performance we can cache assets basically forever and I added the immutable directive.

As explained in the Mozilla documentation:

When a user reloads the browser, the browser will send conditional requests for validating to the origin server. But it's not necessary to revalidate those kinds of static resources even when a user reloads the browser, because they're never modified. immutable tells a cache that the response is immutable while it's fresh and avoids those kinds of unnecessary conditional requests to the server.

For instance, GitHub or Linkedin are already using it in production.

See:

• https://www.keycdn.com/blog/cache-control-immutable
• https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

[jaydrogers]

Today I learned!! Thanks for sharing!

I have a few open source things with Spin that I'm trying to get out the door, but I will circle back and review once I have a chance. I really like where this is going.

[angristan]

I would love this as well 👍 expires is the old way to set cache headers: https://stackoverflow.com/questions/5799906/what-s-the-difference-between-expires-and-cache-control-headers

[jaydrogers]

I am evaluating this for v3.6 and will keep you posted 👍

[jaydrogers]

This all looks great to me! I appreciate you both providing such factual resources for me to learn on this.

I was able to run some tests locally and my "Haha Business" guy had the exact caching experience that I wanted.

I will get this merged in 3.6 👍

[guillaumebriday]

Awesome! Thanks for the merge 👍