Update use cache control immutable for static file

[rogerdz]

Description (*)

Update Cache-Control header to static file (assets, media)
As explained in the Mozilla documentation:
``When a user reloads the browser, the browser will send conditional requests for validating to the origin server. But it's not necessary to revalidate those kinds of static resources even when a user reloads the browser, because they're never modified. immutable tells a cache that the response is immutable while it's fresh and avoids those kinds of unnecessary conditional requests to the server.`
Inspire by:
serversideup/docker-php#487
https://www.keycdn.com/blog/cache-control-immutable

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. Check cache control header static file (js, css, image,...)
   
   
   

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Update use cache control immutable for static site #39486: Update use cache control immutable for static site

[m2-assistant]

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[rogerdz]

@magento run all tests

[engcom-Hotel]

@magento create issue

[hostep]

In my opinion, we should only do this for static assets in /static/ because those assets are versioned and each time we deploy the version changes. So to the browser this looks like a new file after each deploy.
However, it should - in my opinion - NOT be done for static assets in /media/ as there is no guarantee that those are in fact immutable. Merchants can just remove and re-upload a different file with the same filename.
So I would revert the changes done around line 170 in the nginx sample config file.

Also, we should not only update the nginx config file, but also the .htaccess file in pub/static/ used by the Apache httpd webserver.

And we should also be aware that this feature is not fully supported yet by the various major browsers at this moment: https://caniuse.com/mdn-http_headers_cache-control_immutable

[rogerdz]

@magento run all tests

[engcom-Dash]

@engcom-Hotel Could you please review the newly added change ? Moving this for review.

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Hello @rogerdz Thank you for contribution & collaboration!

✔️ QA Passed

Preconditions:

1. Install fresh 2.4-develop instance

Steps to verify:

1. Check cache control header for static file (for eg. js, css, image)

Before: ❌

After: ✔️

For Apache web server:

For Nginx web server:

The builds are failing hence moving this PR for Extended Testing.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B, Functional Tests CE, WebAPI Tests

[engcom-Dash]

The Functional B2B Tests failures in the last two consecutive builds are not consistent. They neither failing because of the code changes done in this PR nor part of this PR.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39484/29b591f8e8076b7852055ac6f866f929/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39484/3228d5a629b3aef2b4ef9bad00293b7f/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

The Functional CE Tests failures in the last two consecutive builds are not consistent. They neither failing because of the code changes done in this PR nor part of this PR.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39484/4a7cb1b94d60c26646cb90631415da00/Functional/allure-report-ce/index.html#categories/bdbf199525818fae7a8651db9eafe741

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39484/e973d3ff1564f8abf88b2a111d10caab/Functional/allure-report-ce/index.html#categories/bdbf199525818fae7a8651db9eafe741

Hence moving this PR in Merge in Progress.