Skip to content

feat: create tests library structure & projects #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 11, 2022

Conversation

followynne
Copy link
Member

@followynne followynne commented Sep 3, 2022

Scope

Create the folder for all test projects.
Create the base test-architecture structure for:

  • MongoDB provider
  • JS UI

@mo-esmp
Copy link
Member

mo-esmp commented Sep 4, 2022

Please send Different PRs for the MongoDB data provider, Fix npm in UI project and test for MongoDB data provider.

@followynne followynne force-pushed the feat/base-test-architecture branch from d574ba6 to ecf165d Compare September 5, 2022 19:48
@followynne followynne changed the title feat: create tests library structure, add MongoDb Provider tests feat: create tests library structure, add MongoDb Provider and JS UI test-projects Sep 5, 2022
@followynne
Copy link
Member Author

followynne commented Sep 5, 2022

Please send Different PRs for the MongoDB data provider, Fix npm in UI project and test for MongoDB data provider.

Hi @mo-esmp
sure, no problem - #45 and #46 😄

I added the JS test structure. If you like the PR, we can merge it (as it only contains the architecture for adding the remaining projects and all the testing)

My plan right now would be:

  1. merge feat: create tests library structure & projects #44 and fix(web): auto-npm-build only on release #45 (as they should have no impact and be useful for future work)
  2. after the merge, I'll rebase perf/idataprovider-extensions #46 onto the main branch and proceed to add all the tests for the MongoDB provider
  3. check and merge perf/idataprovider-extensions #46
  4. merge Improve date management and manipulation #34 (it doesn't have impact and it would be easier to test on the main branch)

After those, it will be easier to add new tests on separate branches 👍

@followynne followynne marked this pull request as ready for review September 5, 2022 20:50
@followynne followynne force-pushed the feat/base-test-architecture branch from c9520bb to b7c9e00 Compare September 6, 2022 20:49
@followynne followynne changed the title feat: create tests library structure, add MongoDb Provider and JS UI test-projects feat: create tests library structure & projects Sep 6, 2022
@mo-esmp mo-esmp merged commit c5f3340 into serilog-contrib:dev Sep 11, 2022
@followynne followynne deleted the feat/base-test-architecture branch September 11, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants