-
Notifications
You must be signed in to change notification settings - Fork 43
Add a SORT-BY option to the UI #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a SORT-BY option to the UI #41
Conversation
…nne/serilog-ui into feature/add-sortable-options
Hey @followynne,
I want to know what is your idea about this matter, should we add tests and then merge and or merge and then add tests? Hence there are several data providers and it's hard to set up and run a sample project to test different data providers manually. |
Hey there @mo-esmp, I get your point, it's painful to not being able to run some tests before merging PR with new feats. About the PR, we can leave it open or merge it without releasing (1st option is better, as I'll commit to create tests soon) - I'll try to squash the Test PR this weekend, if I have time, and setup at least a couple of providers 🎾 |
Thanks @followynne. This weekend finally I can set up my home-office env and be able to focus on writing codes after a long time and start adding tests. As soon as I started, I will let know that I'm going to add tests for what data providers. I guess it's the right time to move the project to Serilog-Contrib and add you as a maintainer and hope to be able to do that this weekend. |
Ciao @mo-esmp That's fantastic news, it's great to hear it! FYI, those days I worked on creating the tests structure and the MongoDB tests, as I already did them in a different project 😃 You can give a check to the branch in this draft PR, if you like it we can work on that branch and add the remaining 👍 For MongoDB, I didn't use testcontainers as MongoRunner is an excellent package to use for integration testing. For the SQL providers, I think we should go with it 100% 😉 (it looks like an awesome project, thanks 1000 for sharing the discovery!) (I'll try to do the same base test configuration for the JS part asap...) |
FYI: I'll leave this PR here and close it soon. I'll reopen it later updated and with tests in the new repo 😊 |
Scope
Add a new sort option to the user interface.
How it works
Fixes
In MongoDb and Elastic providers, the LINQ query order was changed to:
ProviderORMEntry => +Query => +Sort{Prop}{Direction} => +Skip{n} => +Take{n}