Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with setup instructions after TelemetryConfiguration.Active was deprecated #160

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

dglozano
Copy link
Contributor

After going through the thread #121 in order to be able to configure the Sink properly, I thought it might be useful to update the README.md with the instructions on how to set the logger in .NET Core applications after TelemetryConfiguration.Active was deprecated 😄

Add documentation on how to use the sink using .Net Core now that
`TelemetryConfiguration.Active` has been deprecated.
@dglozano dglozano changed the title Update README.md Update README.md with setup instructions after TelemetryConfiguration.Active was deprecated Apr 10, 2021
@vany0114
Copy link
Contributor

I ran into the same issue the only difference is that I'm using this extension from a Generic Host, so the AddApplicationInsightsTelemetry does not work in that scenario, you should use AddApplicationInsightsTelemetryWorkerService from Microsoft.ApplicationInsights.WorkerService. So would be nice to add it to the documentation too, I can do it if you want me to do so.

@dglozano
Copy link
Contributor Author

@vany0114 not sure if instructions to setup ApplicationInsights itself would belong in the Serilog's sink documentation, but I guess it doesn't hurt either 😄 Feel free to add it

@vany0114
Copy link
Contributor

@dglozano I think would be nice just to mention that if you're using a Generic Host you need to use AddApplicationInsightsTelemetryWorkerService rather than AddApplicationInsightsTelemetry (Asp.Net projects) otherwise it does not work, just for the benefit of everyone who runs into that issue (I spent a couple of hours on that)

@vany0114
Copy link
Contributor

vany0114 commented Jun 1, 2021

FYI dglozano#1

@dglozano
Copy link
Contributor Author

dglozano commented Jun 4, 2021

@vany0114 sorry for the delay, it's merged now 😄

@sonic1981
Copy link

This information really need merging in

@nblumhardt nblumhardt changed the base branch from master to dev November 12, 2021 00:08
@nblumhardt nblumhardt merged commit 324894e into serilog-contrib:dev Nov 12, 2021
@nblumhardt nblumhardt mentioned this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants