-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TelemetryConfiguration.Active on README #128
Conversation
TelemetryConfiguration.Active is now obsolete, this commits updates the docs to help new users.
This doesn' work well when used alongside services.AddApplicationInsightsTelemetry() - traces are not correlated with requests correctly. |
@triforcely weren't we supposed to turn off the default |
What about tracking calls to dependencies, performance counters, etc.? I want to store my Serilog logs in AI but still keep tracking other parts of the application. |
Keeping |
@triforcely just checked and tracking remote dependencies and requests are working when using |
Yes, but since they are using two different connections, logs are not as nicely correlated - this is specifically shown in "live metrics". When I was using "Active", I'd get error logs in the telemetry view just after the request was made. After using "CreateDefault()" approach, logs are missing from there. I can still browse the data separately (e.g. query "traces" in logs and view exceptions with dependency tracking) but it is not as good as before, so what I'm trying to suggest is that we need to find a way of getting existing TelemetryConfiguration from DI, because I guess that some "magic" happens internally, when different telemetry sources are batched together. I might be able to do a repro of what I've observed between these two approaches in a few days. |
The suggestion in #160 would be better in most situations. |
I'll close this as #160 is merged, if it's possible to improve that option to make it more discoverable we should work forward from there, I think. Thanks all the same @rodolphocastro ! 👍 |
TelemetryConfiguration.Active is now obsolete, this commits updates the docs to help new users.