Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TelemetryConfiguration.Active on README #128

Closed
wants to merge 1 commit into from

Conversation

rodolphocastro
Copy link

TelemetryConfiguration.Active is now obsolete, this commits updates the docs to help new users.

TelemetryConfiguration.Active is now obsolete, this commits updates the docs to help new users.
@triforcely
Copy link

This doesn' work well when used alongside services.AddApplicationInsightsTelemetry() - traces are not correlated with requests correctly.

@rodolphocastro
Copy link
Author

@triforcely weren't we supposed to turn off the default services.UseApplicationInsights() and instead let this Sink handle it? Got those instructions from Serilog's readme

@triforcely
Copy link

triforcely commented Feb 5, 2020

What about tracking calls to dependencies, performance counters, etc.? I want to store my Serilog logs in AI but still keep tracking other parts of the application.

@rodolphocastro
Copy link
Author

rodolphocastro commented Feb 7, 2020

Keeping services.AddApplicationInsightsTelemetry(); //Inside Startup.ConfigureServices should still give you all the telemetry. I'll double check just to be sure and I'll return to you

@rodolphocastro
Copy link
Author

@triforcely just checked and tracking remote dependencies and requests are working when using TelemetryConfiguration.CreateDefault() alongside services.AddApplicationInsightsTelemetry()

image

@triforcely
Copy link

Yes, but since they are using two different connections, logs are not as nicely correlated - this is specifically shown in "live metrics". When I was using "Active", I'd get error logs in the telemetry view just after the request was made. After using "CreateDefault()" approach, logs are missing from there. I can still browse the data separately (e.g. query "traces" in logs and view exceptions with dependency tracking) but it is not as good as before, so what I'm trying to suggest is that we need to find a way of getting existing TelemetryConfiguration from DI, because I guess that some "magic" happens internally, when different telemetry sources are batched together. I might be able to do a repro of what I've observed between these two approaches in a few days.

@dnperfors
Copy link

The suggestion in #160 would be better in most situations.

@nblumhardt
Copy link
Contributor

I'll close this as #160 is merged, if it's possible to improve that option to make it more discoverable we should work forward from there, I think. Thanks all the same @rodolphocastro ! 👍

@nblumhardt nblumhardt closed this May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants