Deserialize to ArrayString instead of String for ImageHash #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
added
enhancement
arqunis
approved these changes
Jun 24, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
…Hash` (serenity-rs#2467) This saves an allocation on creation of `ImageHash`.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
…Hash` (serenity-rs#2467) This saves an allocation on creation of `ImageHash`.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
…Hash` (serenity-rs#2467) This saves an allocation on creation of `ImageHash`.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
…Hash` (serenity-rs#2467) This saves an allocation on creation of `ImageHash`.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
…Hash` (serenity-rs#2467) This saves an allocation on creation of `ImageHash`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves an allocation on creation of
ImageHash, but adds a new dependency that is not currently in the dep tree at all.I chose the
arrayveccrate oversmallvec,tinyvec, orheaplessas:smallvecwill fall over to heap allocation if length exceeds the capacitytinyvecandsmallvecdoes not include anArrayStringheaplesscontains a lot of unnecessary data structures that may bloat compile time