Deserialize to arrayvec::ArrayString instead of String for `Image…

…Hash` (serenity-rs#2467) This saves an allocation on creation of `ImageHash`.
mkrasnitski · Oct 17, 2023 · 3efc136 · 3efc136
1 parent c2727ec
commit 3efc136
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -29,6 +29,7 @@ futures = { version = "0.3", default-features = false, features = ["std"] }
 dep_time = { version = "0.3.20", package = "time", features = ["formatting", "parsing", "serde-well-known"] }
 base64 = { version = "0.21" }
 secrecy = { version = "0.8.0", features = ["serde"] }
+arrayvec = { version = "0.7.3", features = ["serde"] }
 # Optional dependencies
 fxhash = { version = "0.2.1", optional = true }
 simd-json = { version = "0.7", optional = true }

diff --git a/src/model/misc.rs b/src/model/misc.rs
@@ -111,8 +111,7 @@ impl serde::Serialize for ImageHash {
 
 impl<'de> serde::Deserialize<'de> for ImageHash {
     fn deserialize<D: serde::Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
-        // TODO: Replace this with ArrayString<34>?
-        let helper = String::deserialize(deserializer)?;
+        let helper = arrayvec::ArrayString::<34>::deserialize(deserializer)?;
         Self::from_str(&helper).map_err(serde::de::Error::custom)
     }
 }