Automate prism service on test #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
|
hi @andy-trimble, its already implemented by my change. |
|
@thinkingserious @mbernier This should fix the failing Travis builds. |
|
Hello @andy-trimble, Since @dmitraver grabbed the issue first, could you please help him get across the finish line. Then, you can initiate a new PR that adds in the remaining functionality you added? That way, you both can get Hacktoberfest credit :) With Best Regards, Elmer |
|
Sure thing @thinkingserious. @dmitraver, I added a review to your PR. |
|
Thanks for being awesome @andy-trimble! |
|
@andy-trimble, thanks a lot! I will fix the issues today and update my PR.
…On 10 October 2017 at 02:15, Elmer Thomas ***@***.***> wrote:
Thanks for being awesome @andy-trimble <https://github.com/andy-trimble>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#238 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABtwDDHEXGD-LKKw989nokgfAhTEepBLks5sqrcXgaJpZM4Pv0wD>
.
--
Best wishes,
Dmitry Avershin.
|
Merged
|
See #229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159.
Gradle starts a prism process before testing, then shuts it down after completion.
Note that this PR also updates Gradle to version 3.1.