Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate StopLight.io's Prism mock server on Travis CI and locally #159

Closed
thinkingserious opened this issue Oct 12, 2016 · 15 comments
Closed
Labels
difficulty: hard fix is hard in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community hacktoberfest labels Oct 12, 2016
@felipewmartins
Copy link

Hi @thinkingserious.
I want to contribute to this task.

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing and removed status: help wanted requesting help from the community labels Oct 12, 2016
@thinkingserious
Copy link
Contributor Author

@felipewmartins Awesome!

Please be sure to fill out our CLA so we can merge you changes: https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#cla

@dmitraver
Copy link
Contributor

@felipewmartins hi! are u working on this issue?

@felipewmartins
Copy link

hi @dmitraver. No at this moment.

@dmitraver
Copy link
Contributor

@felipewmartins I can work on that if you are not planning to finish it.

@thinkingserious
Copy link
Contributor Author

Hello Everyone,

Is anyone on this thread still interested in submitting a PR?

Thanks!

@dmitraver
Copy link
Contributor

dmitraver commented Apr 29, 2017 via email

@thinkingserious
Copy link
Contributor Author

Awesome, thanks @dmitraver!

@dmitraver
Copy link
Contributor

FYI I'm gonna push a change for review soon.

@thinkingserious
Copy link
Contributor Author

Hi @dmitraver,

Just checking in. How is it going?

@dmitraver
Copy link
Contributor

hi @thinkingserious,

Started working on that but haven't finished and then simply forgot about it, sorry.

I will try to finish it this week though, thanks for pointing out

@thinkingserious
Copy link
Contributor Author

Thanks @dmitraver!

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 1, 2017
@dmitraver
Copy link
Contributor

hi, I wasn't very active on a github since very long time, was really busy with some other stuff but want to be back on track. I already started last time and nearly get it to work with a local tests. I think I will finish it and make a PR asap.

@dmitraver
Copy link
Contributor

@thinkingserious my original idea was to add the logic of starting the prism in bash script which is executed before running test suite from gradle. I kind of prefer this approach versus having the logic of starting prism from Java. What do you think? I've also seen that the project has a pom.xml which means that if I do it this way I would probably need to add this logic to maven as well.

@thinkingserious
Copy link
Contributor Author

Hi @dmitraver,

So the idea is that at build time prism will be downloaded (if necessary) and run? If so, that sounds good to me.

We also want to provide an easy way to shut down prism. At first I thought we should automatically shut it down after running the tests, but when you are actively developing, you probably want prism to be running for the duration of your development session.

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: hard fix is hard in difficulty and removed difficulty: medium fix is medium in difficulty labels Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

3 participants