output(validation): Pass actual errors instead of status flag only#395
Merged
output(validation): Pass actual errors instead of status flag only#395
Conversation
Copy of #393 since it seems permissions are needed to post the comment. This will unblock the PR, and we can figure out how to fix it for next time
|
Backwards compatibility summary: |
ajbt200128
previously approved these changes
Aug 6, 2025
ajbt200128
reviewed
Aug 6, 2025
Contributor
ajbt200128
left a comment
ajbt200128
left a comment
There was a problem hiding this comment.
@emjin where is the matching PR for this in semgrep? Does this info get sent anywhere to the app? I'm concerned that if so we may overload the app again, like we did when we were sending timeout exceptions (which I assume is a proper subset of core_error)
dijkstracula
approved these changes
Aug 6, 2025
Contributor
Author
|
Matching PR is: https://github.com/semgrep/semgrep-proprietary/pull/4346 |
Contributor
Author
|
Should be fine since this is only used internally to invoke the RPC to get rule error messages from semgrep-core, but let me think again about backwards compatibility |
Contributor
|
Makes sense; that was the only use of it I was aware of either, but wanted to double-check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of #393 since it seems permissions are needed to post the comment. This will unblock the PR, and we can figure out how to fix it for next time
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
semgrep-proprietaryare approved and ready to merge once this PR is merged