output(validation): Pass actual errors instead of status flag only#393
Closed
punchagan wants to merge 1 commit intosemgrep:mainfrom
Closed
output(validation): Pass actual errors instead of status flag only#393punchagan wants to merge 1 commit intosemgrep:mainfrom
punchagan wants to merge 1 commit intosemgrep:mainfrom
Conversation
punchagan
force-pushed
the
punchagan/rpc-validate-errors
branch
from
2f91616 to
8465c88
Compare
punchagan
force-pushed
the
punchagan/rpc-validate-errors
branch
from
8465c88 to
b1ac711
Compare
Contributor
|
Error is about posting the comment, not the actual compatibility. I'll see if I can figure it out on Monday |
emjin
added a commit
that referenced
this pull request
Aug 6, 2025
Copy of #393 since it seems permissions are needed to post the comment. This will unblock the PR, and we can figure out how to fix it for next time
3 tasks
emjin
added a commit
that referenced
this pull request
Aug 8, 2025
) Copy of #393 since it seems permissions are needed to post the comment. This will unblock the PR, and we can figure out how to fix it for next time - [x] I ran `make setup && make` to update the generated code after editing a `.atd` file (TODO: have a CI check) - [x] I made sure we're still backward compatible with old versions of the CLI. For example, the Semgrep backend need to still be able to *consume* data generated by Semgrep 1.50.0. See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades Note that the types related to the semgrep-core JSON output or the semgrep-core RPC do not need to be backward compatible! - [x] Any accompanying changes in `semgrep-proprietary` are approved and ready to merge once this PR is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
semgrep-proprietaryare approved and ready to merge once this PR is merged