-
Notifications
You must be signed in to change notification settings - Fork 8
added docs for catalog hidden_models #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
svetoslavpetkov
wants to merge
1
commit into
main
Choose a base branch
from
v1.2/hidden_models
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,6 +64,14 @@ not need to be unique. | |
|
||
The version of SML being used. | ||
|
||
## hidden_models | ||
|
||
- **Type:** array<string> | ||
- **Required:** Y | ||
- **Added in** v1.2 | ||
|
||
A list of the models that will be excluded from the deploy. Cannot reference composite models, onli | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the msg seems like it was unfinished and with a typo. .."Cannot reference composite models, onli" probably can say something like "Cannot reference composite models." |
||
|
||
## aggressive_agg_promotion | ||
|
||
- **Type:** boolean | ||
|
@@ -114,7 +122,7 @@ Supported properties: | |
- `allow_peer_aggs`: Boolean, optional. Enables aggregation on data | ||
derived from datasets in data warehouses that are different from the | ||
source dataset. | ||
- `allow_preferred_aggs`: Boolean, optional. Allow aggregates to be built | ||
- `allow_preferred_aggs`: Boolean, optional. Allow aggregates to be built | ||
in preferred storage. | ||
|
||
Specify the `unique_name` of the dataset followed by the properties and | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should also include the new property above in under "Sample
catalog
file:". You can check how it is done for aggressive_agg_promotion