Skip to content

added docs for catalog hidden_models #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

svetoslavpetkov
Copy link
Collaborator

No description provided.

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Svetoslav Petkov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@@ -64,6 +64,14 @@ not need to be unique.

The version of SML being used.

## hidden_models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also include the new property above in under "Sample catalog file:". You can check how it is done for aggressive_agg_promotion

- **Required:** Y
- **Added in** v1.2

A list of the models that will be excluded from the deploy. Cannot reference composite models, onli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the msg seems like it was unfinished and with a typo.

.."Cannot reference composite models, onli"

probably can say something like "Cannot reference composite models."

@diannewood
Copy link
Collaborator

I agree with Stanislav's comments. Otherwise it looks good.

@diannewood
Copy link
Collaborator

I just watched the videos (thank you for including them!) and think we should add something about how this feature is used. How about:

Use case: When deploying a composite model the referenced component models may not need to be accessible as separate models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants