Skip to content

Remove deprecated concepts and make associated modifications #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

rjyounes
Copy link
Collaborator

Closes #947.

@rjyounes rjyounes requested a review from uscholdm June 19, 2024 15:15
@rjyounes rjyounes self-assigned this Jun 19, 2024
Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philblackwood @rjyounes
All the unitSymbol changes will be blown away. Might be a merge conflict with PR #1064

@rjyounes
Copy link
Collaborator Author

rjyounes commented Jun 19, 2024

All the unitSymbol changes will be blown away. Might be a merge conflict with PR #1064

@philblackwood Can you change unitSymbol to symbol in your PR? The reference data will also need to be updated.

@philblackwood
Copy link
Contributor

I removed unitSymbol, unitSymbolHtml, and unitSymbolUnicode from gistCore.ttl

I modified the release note issue1033-units-and-magnitudes to say these three deprecated properties are being removed.

I updated the data conversion script replaceProperties to replace all instance of them with gist:symbol

I did not touch any of the other deprecated properties that are in gistCore (isCharacterizedAs, isRecognizedDirectlyBy, tagText) since they are in scope of the issue #1033.

@philblackwood
Copy link
Contributor

Note that gist:symbol is already in gistCore from release 12, so I did not have to change unitSymbol to symbol.

Instead, all that was needed was to remove the deprecated items unitSymbol, unitSymbolHtml, and unitSymbolUnicode.

# Conflicts:
#	ontologies/gistCore.ttl
@rjyounes rjyounes merged commit ab2def1 into develop Jun 24, 2024
1 check passed
@rjyounes rjyounes deleted the ryounes/947_deprecated_concepts branch June 24, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Address deprecated concepts for release 13.0.0
3 participants