gistCore changes to support Units of Measure and Magnitudes #1064

philblackwood · 2024-03-05T15:20:12Z

Adding two classes and one property. Fixes #1033.
Closes #1065.

…t of Measure reference data.

…nitude that represented Aspects. temporary changes to restrictions for consistency (will add back in)

uscholdm

A few suggestions.

ontologies/gistCore.ttl

…y omissions)

…s such as the one for GeoRegion, added hasAspect to class equivalence for Magnitude, and also added the xsd data types that are in the range of numericValue

philblackwood · 2024-03-11T20:02:42Z

Working on release notes. A brief guide to review the new ontology is attached:
Review Guide for Units of Measure.docx

…ules

ontologies/gistCore.ttl

docs/releaseNote1033.md

rjyounes

This is amazing work! I've made some comments related to improving annotations.

ontologies/gistCore.ttl

rjyounes

Additional comments and questions.

ontologies/gistCore.ttl

…ts/gist into modelForReferenceData

uscholdm

Nearly there.

docs/releaseNote1033.md

uscholdm · 2024-06-07T14:36:41Z

docs/releaseNote1033.md

+  - `gist:hasPrecision`
+  - `gist:conversionFactor`
+  - `gist:conversionOffset`
+- Added scripts for the migration of existing client ontologies and instance data. [TODO - add pointer]


Still to add

pointer to what?

Pointer to the "Added scripts for the migration of existing client ontologies and instance data" in the bullet point. I suspect Rebecca added this.

uscholdm · 2024-06-07T14:36:59Z

docs/releaseNote1033.md

+  - `gist:conversionFactor`
+  - `gist:conversionOffset`
+- Added scripts for the migration of existing client ontologies and instance data. [TODO - add pointer]
+- Added complete documentation on understanding and implementing the new model. [TODO - add pointer]


still to add

uscholdm · 2024-06-07T14:49:16Z

docs/releaseNote1033.md

+
+This is a major release that includes several changes which break compatibility with previous versions of gist, most notably an entirely revised model of units and magnitudes. See the [migration guide](./MajorVersionMigration.html) for documentation on updating existing gist-based ontologies and instance data. Migration scripts are included to facilitate the upgrade process.
+
+### Major Updates


This release notes file belongs in the release notes folder.

uscholdm · 2024-06-07T14:50:51Z

docs/releaseNote1033.md

+- Added scripts for the migration of existing client ontologies and instance data. [TODO - add pointer]
+- Added complete documentation on understanding and implementing the new model. [TODO - add pointer]
+
+Import URL: <https://w3id.org/semanticarts/ontology/gistCore13.0.0>.


I don't think this is relevant to units revision.

I believe these are the scripts that @philblackwood wrote in order to identify and amend UoM triples in gist users' stores using the new patterns.

I believe these are the scripts that @philblackwood wrote in order to identify and amend UoM triples in gist users' stores using the new patterns.

Yes, I agree. There is a separate PR for the data conversion scripts,it would be appropriate to have these comments in the other PR

uscholdm · 2024-06-07T16:28:53Z

ontologies/gistCore.ttl

 				owl:onProperty gist:hasAltitude ;
-				owl:someValuesFrom gist:Extent ;
+				owl:someValuesFrom [
+					a owl:Class ;
+					owl:intersectionOf (
+						gist:Magnitude
+						[
+							a owl:Restriction ;
+							owl:onProperty gist:hasAspect ;
+							owl:hasValue gistd:_Aspect_distance ;
+						]
+					) ;
+				] ;


Isn't the recommended pattern to use hasMagnitude and have altitude as the aspect? Here might be a good place to illustrate the pattern where altitude hasBroader distance.

ALso, latitude and longitude could be modeled as aspects that have broader aspect_radian, or some such.

Currently follows the same usage as gist12.

Would be better to use gistd:_Aspect_altitude in the definition. Changed.

ontologies/gistCore.ttl

…ition of GeoPoint

docs/release_notes/issue1033-units-and-magnitudes.md

rjyounes

@philblackwood I think the hasAltitude property should be removed, don't you?

philblackwood · 2024-06-19T15:12:29Z

OK, let's remove hasAltitude. Will do.

…o represent aspects

…, remove hasAltitude

…lUnicode have been removed

uscholdm

@philblackwood - Im not sure which changes have been made, so this may be ready to approve. Apparently I had a few comments stacked up waiting for me to submit review.

ontologies/gistCore.ttl

uscholdm · 2024-06-14T19:51:12Z

docs/releaseNote1033.md

+  - `gist:hasPrecision`
+  - `gist:conversionFactor`
+  - `gist:conversionOffset`
+- Added scripts for the migration of existing client ontologies and instance data. [TODO - add pointer]


Pointer to the "Added scripts for the migration of existing client ontologies and instance data" in the bullet point. I suspect Rebecca added this.

ontologies/gistCore.ttl

docs/release_notes/issue1033-units-and-magnitudes.md

kchastain703

This looks good to me.

Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>

# Conflicts: # ontologies/gistCore.ttl

All requested changes have been addressed.

adding Discipline, UnitGroup, and hasUnitGroup to gist to support Uni…

28d8d9f

…t of Measure reference data.

philblackwood marked this pull request as draft March 5, 2024 15:20

philblackwood self-assigned this Mar 5, 2024

philblackwood changed the title ~~changes to support UoM reference data~~ gistCore changes to support UoM reference data Mar 5, 2024

philblackwood added 2 commits March 5, 2024 15:42

more changes to support new Units of Measure

0e51e0e

removed individual units, removed subclasses of UnitOfMeasure and Mag…

178585d

…nitude that represented Aspects. temporary changes to restrictions for consistency (will add back in)

uscholdm reviewed Mar 5, 2024

View reviewed changes

philblackwood added 3 commits March 6, 2024 12:19

hasMultipler, hasDivisor, hasAddend, hasSubtrahend (and some temporar…

467e2f7

…y omissions)

added individual Aspects and used them in class equivalence statement…

d160949

…s such as the one for GeoRegion, added hasAspect to class equivalence for Magnitude, and also added the xsd data types that are in the range of numericValue

minor edit

9382d59

philblackwood changed the title ~~gistCore changes to support UoM reference data~~ gistCore changes to support Units of Measure and Magnitudes Mar 11, 2024

philblackwood requested review from rjyounes, uscholdm and Jamie-SA March 11, 2024 19:59

philblackwood added 2 commits March 12, 2024 13:30

attempt to fix error

642ed56

release note for issue #1033 turtle for Units of Measure and Magnitude

ceee2f3

rjyounes marked this pull request as ready for review March 14, 2024 15:06

rjyounes requested a review from mkumba March 14, 2024 15:06

another attempt to get format of exponents to conform to validation r…

a6b44e5

…ules

philblackwood requested a review from kchastain703 April 2, 2024 15:19

philblackwood added 2 commits April 10, 2024 10:36

remove domain from numericValue

cdc5732

wording change in scopeNote of UnitGroup, wording change in hasUnitGroup

f9636a6

kchastain703 reviewed Apr 10, 2024

View reviewed changes

ontologies/gistCore.ttl Show resolved Hide resolved

using lower case in annotations

d0fc912

rjyounes reviewed Apr 12, 2024

View reviewed changes

docs/releaseNote1033.md Outdated Show resolved Hide resolved

rjyounes requested changes Apr 12, 2024

View reviewed changes

ontologies/gistCore.ttl Show resolved Hide resolved

ontologies/gistCore.ttl Outdated Show resolved Hide resolved

ontologies/gistCore.ttl Outdated Show resolved Hide resolved

ontologies/gistCore.ttl Show resolved Hide resolved

Simplify release notes

3386a90

rjyounes reviewed Apr 12, 2024

View reviewed changes

ontologies/gistCore.ttl Show resolved Hide resolved

philblackwood and others added 4 commits June 3, 2024 11:01

change balance to financial balance

8713e56

Merge branch 'modelForReferenceData' of https://github.com/semanticar…

a2d986d

…ts/gist into modelForReferenceData

Merge branch 'develop' into modelForReferenceData

09f4bdf

Merge branch 'modelForReferenceData' of https://github.com/semanticar…

0c57fb3

…ts/gist into modelForReferenceData

uscholdm requested changes Jun 7, 2024

View reviewed changes

changed hasPrecision to hasAccuracy

f3ab841

rjyounes approved these changes Jun 13, 2024

View reviewed changes

philblackwood added 5 commits June 13, 2024 11:51

changed gist:Duration to duration in an annotation

ea8f7ad

use gistd:_Aspect_altitude instead of gistd:_Aspect_distance in defin…

b1e0301

…ition of GeoPoint

put uom release notes in correct directory and improve file name

15254f6

put uom release notes in correct directory and improve file name

a885446

change hasAltitude to hasMagnitude in class equivalence for GeoPoint

d3dc1da

kchastain703 reviewed Jun 18, 2024

View reviewed changes

docs/release_notes/issue1033-units-and-magnitudes.md Show resolved Hide resolved

rjyounes requested changes Jun 19, 2024

View reviewed changes

philblackwood added 2 commits June 19, 2024 11:23

removed hasAltitude because it does not conform to the standard way t…

5047a95

…o represent aspects

updated release notes to include changing hasPrecision to hasAccuracy…

adce658

…, remove hasAltitude

uscholdm mentioned this pull request Jun 19, 2024

Remove deprecated concepts and make associated modifications #1107

Merged

philblackwood added 2 commits June 20, 2024 12:39

removed unitSymbol, unitSymbolHtml, and unitSymbolUnicode

9f2ac77

updated release note to say unitSymbol, unitSymbolHtml, and unitSymbo…

cdf7fe1

…lUnicode have been removed

uscholdm previously requested changes Jun 20, 2024

View reviewed changes

kchastain703 approved these changes Jun 21, 2024

View reviewed changes

Update ontologies/gistCore.ttl

f1158de

Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>

rjyounes requested review from rjyounes and Jamie-SA June 24, 2024 13:31

rjyounes approved these changes Jun 24, 2024

View reviewed changes

Merge branch 'develop' into modelForReferenceData

915ccd9

# Conflicts: # ontologies/gistCore.ttl

rjyounes merged commit 063d8b8 into develop Jun 24, 2024
1 check passed

rjyounes deleted the modelForReferenceData branch June 24, 2024 13:41


		This is a major release that includes several changes which break compatibility with previous versions of gist, most notably an entirely revised model of units and magnitudes. See the [migration guide](./MajorVersionMigration.html) for documentation on updating existing gist-based ontologies and instance data. Migration scripts are included to facilitate the upgrade process.

		### Major Updates

gistCore changes to support Units of Measure and Magnitudes #1064

gistCore changes to support Units of Measure and Magnitudes #1064

Uh oh!

Conversation

philblackwood commented Mar 5, 2024 • edited by rjyounes Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uscholdm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philblackwood commented Mar 11, 2024

Uh oh!

Uh oh!

Uh oh!

rjyounes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rjyounes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

uscholdm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rjyounes left a comment

Choose a reason for hiding this comment

Uh oh!

philblackwood commented Jun 19, 2024

Uh oh!

uscholdm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

philblackwood commented Mar 5, 2024 •

edited by rjyounes

Loading