uom data conversion explanation and queries #1071
Conversation
philblackwood
requested review from
mkumba,
rjyounes,
uscholdm,
Jamie-SA and
kchastain703
|
I don't think I know how to do a git review and or approval, or if I know what I'd be looking at. There appears to be a lot to look at.
On Apr 2, 2024, at 9:18 AM, Phil Blackwood ***@***.***> wrote:
@philblackwood<https://github.com/philblackwood> requested your review on: #1071<#1071> uom data conversion explanation and queries.
—
Reply to this email directly, view it on GitHub<#1071 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAAGJPVGOV7YTGKZJUL7HPLY3LD43AVCNFSM6AAAAABFTTDM3WVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGMZDOOBRGI2TQNA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
@philblackwood @rjyounes I want to make comments in the PowerPoint deck, what is the best way for me to do that? One way is to make a separate copy and email it to Phil who can make any desired changes and then make another commit. How can I do it more publicly on git? |
|
You can make comments or modifications in a copy and then upload it into a GitHub comment.
From: Michael Uschold ***@***.***>
Date: Tuesday, April 2, 2024 at 3:27 PM
To: semanticarts/gist ***@***.***>
Cc: Rebecca Younes ***@***.***>, Mention ***@***.***>
Subject: Re: [semanticarts/gist] uom data conversion explanation and queries (PR #1071)
@philblackwood<https://github.com/philblackwood> @rjyounes<https://github.com/rjyounes> I want to make comments in the PowerPoint deck, what is the best way for me to do that? One way is to make a separate copy and email it to Phil who can make any desired changes and then make another commit. How can I do it more publicly on git?
—
Reply to this email directly, view it on GitHub<#1071 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAM5PZFOCFM667RSYINZYHTY3MBCVAVCNFSM6AAAAABFTTDM3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSHE2DGMJSG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Very impressive overall, and also fairly complicated. and hard to follow. Would be much easier if there were examples. Has every one of the queries been road tested?
Also, the lack of availability of the unit ref data makes it more or less impossible for anyone to do the conversion.
| construct { | ||
| ?broaderAspect ?broaderAspectPredicate ?broaderAspectObject . | ||
| ?unitGroup ?unitGroupPredicate ?unitGroupObject . | ||
| ?unitOfMeasure ?unitOfMeasurePredicate ?unitOfMeasureObject . | ||
| } |
There was a problem hiding this comment.
An example would be super useful here. I found it difficult to make one up, in part because of the abstraction.
- broaderAspectPredicate
- unitGroupPredicate
- unitOfMeasurePredicate
i would not epect these to vary, so much easier to just put them in.
There was a problem hiding this comment.
This is a copy of the deck with comments and a few added slides.
There was a problem hiding this comment.
Updates included:
Remove slide showing SA internal process steps of updating, validating, and extracting subset of reference data for client.
Clarify that client reference data is not the full data reference data set, only the subset used by the client.
Improve diagrams (":" before Area and remove diagram using hasAspect).
Remove double arrows from mapping between SA reference data and client existing data.
Complete model is not included because it is not required to do the conversion.
There was a problem hiding this comment.
Complete model is not included because it is not required to do the conversion.
ok
There was a problem hiding this comment.
Improve diagrams (":" before Area and remove diagram using hasAspect).
I don't detect a removed diagram.
There is no ':' in the current copy as of commit:
Commit: 254f981 [254f981]
Parents: 28275d3
Author: philblackwood phil.blackwood@semanticarts.com
Date: Monday, 10 June, 2024 10:50:23
Committer: philblackwood
There was a problem hiding this comment.
Remove double arrows from mapping between SA reference data and client existing data.
The double arrows are still there. Perhaps you made changes but they did not make it to the commit?
There was a problem hiding this comment.
changes committed and pushed
…ta and validate reference data)
…d change from hasPrecision to hasAccuracy
There was a problem hiding this comment.
Phil and I have had several go-rounds on this and it keeps improving to the point where we are mostly just fine-tuning.
… unitSymbolUnicode with symbol
Unit of Measure data conversion steps (powerpoint) and SPARQL. Fixes #1034.