Skip to content

Introduce enableSudo param to control whether the desktop container can gain sudo privileges. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce enableSudo param to control whether the desktop container can gain sudo privileges. #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions manifests/brokerapp-base/webrtc-bundle-manifests/resource-vdi-deploy.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@
{{- $watchdogImage = .AppParams.watchdogImage}}
{{- end}}

{{- $enableSudo := true}}
{{- if .AppParams.enableSudo }}
{{- if eq .AppParams.enableSudo "false"}}
{{- $enableSudo = false }}
{{- end}}
{{- end}}

###
# TODO: figure out how to remove this service.
# It's not needed with the deployment type brokerapp but is needed for templating patches.
Expand Down Expand Up @@ -124,6 +131,7 @@ spec:
privileged: false
runAsUser: 1000
runAsGroup: 1000
allowPrivilegeEscalation: {{$enableSudo}}
env:
- name: VDI_USER
value: "{{.App}}"
Expand Down
9 changes: 9 additions & 0 deletions manifests/brokerapp-base/webrtc-bundle-manifests/resource-vdi-statefulset.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@
{{- end}}
{{- end}}

{{- $enableSudo := true}}
{{- if .AppParams.enableSudo }}
{{- if eq .AppParams.enableSudo "false"}}
{{- $enableSudo = false }}
{{- end}}
{{- end}}


apiVersion: v1
kind: Service
metadata:
Expand Down Expand Up @@ -149,6 +157,7 @@ spec:
privileged: false
runAsUser: 1000
runAsGroup: 1000
allowPrivilegeEscalation: {{$enableSudo}}
env:
- name: VDI_USER
value: "{{.User}}"
Expand Down