Skip to content

Conversation

@reisbel
Copy link
Contributor

@reisbel reisbel commented Aug 7, 2022

Introduce a brokerappconfig param to control whether the desktop container can gain sudo privileges.

Description: control whether the desktop container can gain sudo privileges.
Path: spec.appParams.enableSudo
Default value: true
Usage

#spec.appParams.enableSudo
spec:
 #appParams section
 appParams:
   - name: enableSudo
     default: "false"

@reisbel reisbel requested a review from danisla August 7, 2022 05:36
@reisbel reisbel changed the title Enable Sudo brokerappconfig param Introduce enableSudo param to control whether the desktop container can gain sudo privileges. Aug 7, 2022
@danisla
Copy link
Member

danisla commented Aug 16, 2022

This might break the docker compatibility feature, the docker.sock is created in the xpra entrypoint https://github.com/selkies-project/selkies-vdi/blob/master/manifests/brokerapp-base/webrtc-bundle-manifests/jsonpatch-deploy-xpra.yaml.tmpl#L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants