-
Notifications
You must be signed in to change notification settings - Fork 867
added a config parameter to limit outbound p2p connections. #2974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+894
−277
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5a5bd0e
code complete, need tests
pompon0 5236044
tests pass
pompon0 67d1450
one test
pompon0 8586dfe
test coverage
pompon0 4bcab2c
compilation fix:
pompon0 3a95500
Merge branch 'main' into gprusak-outbound
pompon0 6817070
pool tests
pompon0 5ea16eb
more tests
pompon0 68d24ce
applied comments
pompon0 128f5bc
Merge branch 'main' into gprusak-outbound
pompon0 a580e70
unconditional is persistent
pompon0 1e9c656
clamp
pompon0 ab71689
moved clamping to the config conversion
pompon0 35e2f71
Merge branch 'main' into gprusak-outbound
pompon0 a8ff3f2
Merge branch 'gprusak-outbound0' into gprusak-outbound
pompon0 68e2196
Merge remote-tracking branch 'origin/main' into gprusak-outbound0
pompon0 c468308
Merge branch 'gprusak-outbound0' into gprusak-outbound
pompon0 ed899f5
lint
pompon0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe we should give a guideline how much lower this should be compared to MaxConnections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, I don't know that yet :). I estimate 10 outbound, 50 total, but this is tbd.