added a config parameter to limit outbound p2p connections. by pompon0 · Pull Request #2974 · sei-protocol/sei-chain

pompon0 · 2026-02-24T18:19:52Z

For a healthy p2p network nodes should provide more capacity than they consume. This PR adds a limit on the number of outbound connections, so that a node does not try to fill up ALL of the available connection slots that it has, but rather to establish just a reasonable number of connections and let other nodes connect to it. Additionally:

logic for managing a pool of connections has been extracted from peerManagerInner to a separate type (we have regular and persistent pools)
wired up the HandshakeTimeout, DialTimeout and a couple other P2P config fields which were not properly copied to routeroptions.

github-actions · 2026-02-24T18:20:48Z

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`✅ passed`	Feb 25, 2026, 6:01 PM

sei-tendermint/internal/p2p/peermanager_pool.go

+		for old := range pa.fails {
+			failedAddr = utils.Some(old)
+			break
+		}


sei-tendermint/internal/p2p/peermanager_pool.go

+		return
+	}
+	// Record the failure time.
+	now := time.Now()


sei-tendermint/internal/p2p/peermanager_pool.go

+	for old, pa := range p.addrs {
+		if len(pa.fails) < len(pa.addrs) {
+			continue
+		}
+		return old, true
+	}


sei-tendermint/internal/p2p/peermanager_pool.go

+	for id, peerAddrs := range p.addrs {
+		if _, ok := p.dialing[id]; ok {
+			continue
+		}
+		if _, ok := p.conns[id]; ok {
+			continue
+		}
+		if x, ok := bestPeer.Get(); !ok || before(peerAddrs.lastFail, x.lastFail) {
+			bestPeer = utils.Some(peerAddrs)
+		}
+	}


sei-tendermint/internal/p2p/peermanager_pool.go

+		for addr := range peer.addrs {
+			if x, ok := best.Get(); !ok || before(getOpt(peer.fails, addr), getOpt(peer.fails, x)) {
+				best = utils.Some(addr)
+			}
+		}


codecov · 2026-02-24T18:39:34Z

Codecov Report

❌ Patch coverage is 92.41071% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.45%. Comparing base (82fb610) to head (ed899f5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
sei-tendermint/internal/p2p/peermanager.go	74.13%	13 Missing and 2 partials ⚠️
sei-tendermint/internal/p2p/peermanager_pool.go	98.31%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2974       +/-   ##
===========================================
+ Coverage   58.11%   68.45%   +10.33%     
===========================================
  Files        2109       40     -2069     
  Lines      173394     3959   -169435     
===========================================
- Hits       100771     2710    -98061     
+ Misses      63675     1007    -62668     
+ Partials     8948      242     -8706

Flag	Coverage Δ
sei-chain	`68.30% <92.41%> (+10.22%)`	⬆️
sei-db	`69.50% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
sei-tendermint/config/config.go	`70.22% <100.00%> (+0.06%)`	⬆️
sei-tendermint/internal/p2p/routeroptions.go	`86.36% <100.00%> (-0.31%)`	⬇️
sei-tendermint/libs/utils/im/im.go	`69.04% <100.00%> (+8.44%)`	⬆️
sei-tendermint/libs/utils/math.go	`100.00% <100.00%> (ø)`
sei-tendermint/libs/utils/proto.go	`26.19% <ø> (-6.42%)`	⬇️
sei-tendermint/libs/utils/testonly.go	`71.69% <100.00%> (+1.10%)`	⬆️
sei-tendermint/node/setup.go	`67.39% <100.00%> (+2.15%)`	⬆️
sei-tendermint/internal/p2p/peermanager_pool.go	`98.31% <98.31%> (ø)`
sei-tendermint/internal/p2p/peermanager.go	`79.67% <74.13%> (-11.68%)`	⬇️

... and 2075 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

wen-coding

I think this looks reasonable. However, if there is semantics change, I'd slightly prefer to split semantics change into another PR if possible. Just in case there is any emergency, it would be much easier to diagnose problems.

sei-tendermint/config/config.go

wen-coding · 2026-02-24T18:23:48Z

sei-tendermint/config/config.go

 	MaxConnections uint16 `mapstructure:"max-connections"`

+	// MaxConnections limits the number of outbound peers.
+	// It should be significantly lower than MaxConnections, unless


nit: maybe we should give a guideline how much lower this should be compared to MaxConnections

well, I don't know that yet :). I estimate 10 outbound, 50 total, but this is tbd.

sei-tendermint/config/config.go

wen-coding · 2026-02-25T00:42:45Z

sei-tendermint/internal/p2p/peermanager.go

 func (i *peerManagerInner[C]) TryStartDial(persistentPeer bool) (NodeAddress, bool) {
 	// Check concurrent dials limit.
-	if len(i.dialing) >= i.options.maxDials() {
+	if len(i.regular.dialing)+len(i.persistent.dialing) >= i.options.maxDials() {


should we cleanly split everything (including maxdials) between the two pool?

probably, but that's more configuration. We can reconsider that later.

sei-tendermint/config/config.go

wen-coding · 2026-02-25T00:47:34Z

sei-tendermint/internal/p2p/peermanager.go

-	if !i.isPersistent(id) {
-		delete(i.addrs, id)
-	}
-	if !i.isUnconditional[id] {


originally even when id is persistent we will close connection if it's not unconditional, we don't need this any more?

all persistent peers are unconditional (see the old newPeerManager impl). In this pr I've merged the unconditional and persistent to be the same concept (see pr description) to simplify the situation a bit.

wen-coding · 2026-02-25T00:54:49Z

sei-tendermint/libs/utils/im/im.go

 	return Map[K, V]{m.m.Set(key, value)}
 }

+func (m Map[K, V]) SetOpt(key K, mvalue utils.Option[V]) Map[K, V] {


nit: SetOpt sounds like it will do nothing if the key doesn't exist, how about SetOrDelete or something like that.

It is dual to getopt. I've added documentation. I can change to SetOrDelete if you feel strongly about this.

wen-coding · 2026-02-25T01:05:12Z

sei-tendermint/internal/p2p/peermanager_pool.go

+}
+
+type poolConfig struct {
+	selfID          types.NodeID


nit: would you use different selfID on different pools?

No, but I want the pools to be self contained.

wen-coding · 2026-02-25T01:22:42Z

sei-tendermint/internal/p2p/peermanager.go

+		isPersistent: map[types.NodeID]bool{},
+		conns:        utils.NewAtomicSend(im.NewMap[types.NodeID, C]()),
+
+		persistent: newPool[C](poolConfig{selfID: selfID}),


Where are the metrics? Should we split metrics by pool as well?

there is a metric for the total number of connections, there is a log printed every 10s with number of connections (regular vs persistent) and there is network state exposed via net_info rpc endpoint. Metrics and the rpc endpoint need a revamp indeed but it is out of scope of this pr.

sei-tendermint/libs/utils/math.go

+package utils
+
+import (
+	"unsafe"


pompon0 added 4 commits February 24, 2026 15:18

code complete, need tests

5a5bd0e

tests pass

5236044

one test

67d1450

test coverage

8586dfe

pompon0 requested review from sei-will and wen-coding February 24, 2026 18:19

pompon0 added the non-app-hash-breaking label Feb 24, 2026

pompon0 added 2 commits February 24, 2026 19:24

compilation fix:

4bcab2c

Merge branch 'main' into gprusak-outbound

3a95500

github-advanced-security bot found potential problems Feb 24, 2026

View reviewed changes

wen-coding reviewed Feb 25, 2026

View reviewed changes

pompon0 added 5 commits February 25, 2026 13:56

pool tests

6817070

more tests

5ea16eb

applied comments

68d24ce

Merge branch 'main' into gprusak-outbound

128f5bc

unconditional is persistent

a580e70

sei-will approved these changes Feb 25, 2026

View reviewed changes

pompon0 added 2 commits February 25, 2026 17:33

clamp

1e9c656

moved clamping to the config conversion

ab71689

pompon0 requested a review from wen-coding February 25, 2026 16:44

github-advanced-security bot found potential problems Feb 25, 2026

View reviewed changes

sei-tendermint/libs/utils/math.go Fixed Show fixed Hide fixed

wen-coding approved these changes Feb 25, 2026

View reviewed changes

pompon0 added 4 commits February 25, 2026 18:49

Merge branch 'main' into gprusak-outbound

35e2f71

Merge branch 'gprusak-outbound0' into gprusak-outbound

a8ff3f2

Merge remote-tracking branch 'origin/main' into gprusak-outbound0

68e2196

Merge branch 'gprusak-outbound0' into gprusak-outbound

c468308

pompon0 enabled auto-merge (squash) February 25, 2026 17:52

lint

ed899f5

github-advanced-security bot found potential problems Feb 25, 2026

View reviewed changes

sei-tendermint/libs/utils/math.go

package utils

import (

"unsafe"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism

pompon0 merged commit 89daf14 into main Feb 25, 2026
38 checks passed

pompon0 deleted the gprusak-outbound branch February 25, 2026 18:15

Conversation

pompon0 commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check warning

Check warning

Check warning

Check warning

Check warning

codecov bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wen-coding left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Check notice

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pompon0 commented Feb 24, 2026 •

edited

Loading

github-actions bot commented Feb 24, 2026 •

edited

Loading

codecov bot commented Feb 24, 2026 •

edited

Loading