Fix: Comprehensive improvements and test enhancements

.github/workflows/php.yml

@@ -14,6 +14,11 @@ jobs:
     steps:
     - uses: actions/checkout@v2
 
+    - name: Setup PHP
+      uses: actions/setup-php@v2
+      with:
+        php-version: '7.4'
+
     - name: Validate composer.json and composer.lock
       run: composer validate
 
@@ -33,5 +38,5 @@ jobs:
     # Add a test script to composer.json, for instance: "test": "vendor/bin/phpunit"
     # Docs: https://getcomposer.org/doc/articles/scripts.md
 
-    # - name: Run test suite
-    #   run: composer run-script test
+    - name: Run test suite
+      run: composer run-script test

composer.json

@@ -12,7 +12,7 @@
         }
     ],
     "require": {
-        "php": "^7.2"
+        "php": "^7.4"
     },
     "keywords": ["PHP", "laravel", "Regex", "Persian Regex", "Pregex", "Sedhossein"],
     "require-dev" : {
@@ -31,5 +31,8 @@
         "psr-4": {
             "Sedhossein\\Pregex\\Tests\\": "tests/"
         }
+    },
+    "scripts": {
+        "test": "vendor/bin/phpunit"
     }
 }

src/Pregex.php

@@ -110,9 +110,6 @@ public function IsIban(string $value): bool
         return $tmpValue != 1 ? false : true;
     }
 
-    /**
-     * @codeCoverageIgnore
-     */
     public function IsNationalCode(string $value): bool
     {
         if (

tests/PregexTest.php

@@ -203,6 +203,9 @@ public function ValidNationalCode(): array
         return [
             // TODO: this repo tested with personal national code,
             // but for security issues i ignore this test on open-source
+            ["0012345679"],
+            ["1234567891"],
+            ["0499528654"],
         ];
     }
 
@@ -212,7 +215,11 @@ public function InvalidNationalCode(): array
             ["0000000000"], ["1111111111"], ["2222222222"],
             ["3333333333"], ["4444444444"], ["5555555555"],
             ["6666666666"], ["7777777777"], ["8888888888"],
-            ["9999999999"], [""]
+            ["9999999999"], [""],
+            ["0012345670"], // incorrect control digit
+            ["1234567"],    // too short
+            ["12345678901"],// too long
+            ["abcdefghij"], // non-numeric
         ];
     }
 
@@ -451,7 +458,7 @@ public function invalid_persian_names(): array
     // ============================== Without Persian Alphabet validations ==============================
 
     /**
-     * @dataProvider test_invalid_without_persian_alphabet
+     * @dataProvider valid_without_persian_alphabets
      */
     public function test_valid_without_persian_alphabet(string $string)
     {