Fix: Comprehensive improvements and test enhancements #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces several key improvements to the codebase:
1. **Updated PHP Version:**
- Raised the minimum PHP version requirement in `composer.json` from `^7.2` to `^7.4`.
2. **CI Enhancements (`.github/workflows/php.yml`):**
- Configured the GitHub Actions workflow to explicitly use PHP 7.4.
- Enabled the test suite execution step, which was previously commented out.
3. **Enabled Composer Test Script:**
- Added a `test` script (`vendor/bin/phpunit`) to `composer.json` to facilitate running tests.
4. **National Code Validation Tests (`IsNationalCode`):**
- Added comprehensive test cases for the `IsNationalCode` method in `PregexTest.php`, including valid (generated, non-real) and invalid scenarios.
- Removed the `@codeCoverageIgnore` annotation from the `IsNationalCode` method in `Pregex.php` as it is now covered by tests.
5. **Test Naming Correction:**
- Corrected a data provider annotation in `PregexTest.php`: The `test_valid_without_persian_alphabet` method now correctly uses the `valid_without_persian_alphabets` data provider.
These changes improve the reliability of the library by ensuring tests are run in CI, modernize the PHP dependency, and increase test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several key improvements to the codebase:
Updated PHP Version:
composer.jsonfrom^7.2to^7.4.CI Enhancements (
.github/workflows/php.yml):Enabled Composer Test Script:
testscript (vendor/bin/phpunit) tocomposer.jsonto facilitate running tests.National Code Validation Tests (
IsNationalCode):IsNationalCodemethod inPregexTest.php, including valid (generated, non-real) and invalid scenarios.@codeCoverageIgnoreannotation from theIsNationalCodemethod inPregex.phpas it is now covered by tests.Test Naming Correction:
PregexTest.php: Thetest_valid_without_persian_alphabetmethod now correctly uses thevalid_without_persian_alphabetsdata provider.These changes improve the reliability of the library by ensuring tests are run in CI, modernize the PHP dependency, and increase test coverage.