Move hexDecode test helper into a test file #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inclusion of the test helper outside of a _test.go file results
in any downstream consumer of this library, either directly or
transitively, having the testing package reachable in their binaries.
See the following dependency tree for an example which shows how
`testing` ends up being included in `github.com/sigstore/sigstore-go`.
```bash
goda tree "reach(github.com/sigstore/sigstore-go/pkg/tlog...:all, testing)"
├ github.com/sigstore/sigstore-go/pkg/tlog
├ github.com/sigstore/rekor/pkg/types/dsse/v0.0.1
└ github.com/in-toto/in-toto-golang/in_toto
└ github.com/secure-systems-lab/go-securesystemslib/signerverifier
└ github.com/sigstore/rekor/pkg/types/intoto/v0.0.2
└ github.com/in-toto/in-toto-golang/in_toto ~
```
Since the hexDecode helper was only being consumed in tests it was
relocated from signerverifier/utils.go to signerverifier/utils_test.go.
|
@adityasaky would you, or someone else from your team, be able to take a look at this? |
|
@adityasaky would you be able to cut a new tag with this change? |
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inclusion of the test helper outside of a _test.go file results in any downstream consumer of this library, either directly or transitively, having the testing package reachable in their binaries. See the following dependency tree for an example which shows how
testingends up being included ingithub.com/sigstore/sigstore-go.Since the hexDecode helper was only being consumed in tests it was relocated from signerverifier/utils.go to signerverifier/utils_test.go.