Merge pull request #122 from rosstimothy/tross/remove_testing

Move hexDecode test helper into a test file

Author: adityasaky

signerverifier/utils.go

@@ -8,7 +8,6 @@ import (
 	"encoding/pem"
 	"errors"
 	"hash"
-	"testing"
 
 	"github.com/secure-systems-lab/go-securesystemslib/cjson"
 )
@@ -141,12 +140,3 @@ func hashBeforeSigning(data []byte, h hash.Hash) []byte {
 	h.Write(data)
 	return h.Sum(nil)
 }
-
-func hexDecode(t *testing.T, data string) []byte {
-	t.Helper()
-	b, err := hex.DecodeString(data)
-	if err != nil {
-		t.Fatal(err)
-	}
-	return b
-}

signerverifier/utils_test.go

@@ -1,13 +1,23 @@
 package signerverifier
 
 import (
+	"encoding/hex"
 	"os"
 	"path/filepath"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 )
 
+func hexDecode(t *testing.T, data string) []byte {
+	t.Helper()
+	b, err := hex.DecodeString(data)
+	if err != nil {
+		t.Fatal(err)
+	}
+	return b
+}
+
 func TestLoadKeyFromSSLibBytes(t *testing.T) {
 	t.Run("RSA public key", func(t *testing.T) {
 		contents, err := os.ReadFile(filepath.Join("test-data", "rsa-test-key.pub"))