Skip to content

#3512 Add UX for marking water exclusion surfaces #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

#3512 Add UX for marking water exclusion surfaces #3645

merged 1 commit into from
Mar 3, 2025

Conversation

maxim-productengine
Copy link
Contributor

"Hide water" checkbox is added to allow mark selected face(s) as water exclusion surface(invisiprim).

  • Checkbox is disabled if selected face has pbr material or media;
  • Confirmation dialog appears when user checks the box;
  • When the box is checked, all other controls are disabled.

@github-actions github-actions bot added the c/cpp label Mar 3, 2025
Geenz
Geenz approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@Geenz Geenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@maxim-productengine maxim-productengine merged commit a1ccb44 into release/2025.03 Mar 3, 2025
11 checks passed
@maxim-productengine maxim-productengine deleted the maxim/2025.03-3512 branch March 3, 2025 20:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
@maxim-productengine maxim-productengine linked an issue Mar 4, 2025 that may be closed by this pull request
Add UX for marking water exclusion surfaces #3512
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Geenz Geenz Geenz approved these changes

@akleshchev akleshchev akleshchev approved these changes

@marchcat marchcat marchcat approved these changes

Assignees
No one assigned
Labels
c/cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add UX for marking water exclusion surfaces
4 participants
@maxim-productengine @Geenz @akleshchev @marchcat