golangci-lint: upgrade the action #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the golangci-lint GitHub Action version while adding error logging for response body closures in the client code.
- Upgraded the golangci-lint Action from v6 to v7 in the workflow file.
- Refactored the defer statements in lib/client.go to log errors when closing the HTTP response body.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/client.go | Updated defer functions with inline error logging for response body closures. |
| .github/workflows/pre-main.yml | Upgraded golangci-lint Action version from v6 to v7. |
Comments suppressed due to low confidence (2)
lib/client.go:52
- [nitpick] Consider using a structured logging mechanism instead of fmt.Printf for error reporting to improve consistency and maintainability in production code.
err := httpResponse.Body.Close()
lib/client.go:108
- [nitpick] Consider using a structured logging mechanism instead of fmt.Printf for error reporting to improve consistency and maintainability in production code.
err := httpResponse.Body.Close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: redhat-best-practices-for-k8s/certsuite#2875