-
Notifications
You must be signed in to change notification settings - Fork 34
golangci-lint: migration to v2 #2875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sebrandon1
merged 1 commit into
redhat-best-practices-for-k8s:main
from
sebrandon1:golangci-lint-migration
Mar 25, 2025
Merged
golangci-lint: migration to v2 #2875
sebrandon1
merged 1 commit into
redhat-best-practices-for-k8s:main
from
sebrandon1:golangci-lint-migration
Mar 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from change #2875: |
7e1e152
to
75e42ca
Compare
from change #2875: |
acornett21
reviewed
Mar 25, 2025
75e42ca
to
734a436
Compare
734a436
to
0c0312f
Compare
from change #2875: |
be24a41
into
redhat-best-practices-for-k8s:main
48 of 55 checks passed
from change #2875: |
This was referenced Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://golangci-lint.run/product/migration-guide/
I migrated the config over to their
v2
style with themigrate
command. Also I fixed a number of things it started flagging.