Set exclude var to "/" if its an empty string after removing the basepath

[IceShack]

With following testsuites configuration, the php-file-iterator returned a PHP warning
To prevent this warning I suggest that if the $_exclude var ist empty after removing the basepath it should be set to '/'.

Testsuite configuration:

<testsuites>
    <testsuite name="some">
        <directory>../src/Acme/SomeBundle/Tests</directory>
    </testsuite>
    <testsuite name="other">
        <directory>../src/*/*Bundle/Tests</directory>
        <directory>../src/*/*/*Bundle/Tests</directory>
        <exclude>../src/Acme/SomeBundle/Tests</exclude>
    </testsuite>
</testsuites>

PHP-Warning:

PHP Warning:  strpos(): Empty needle in /some-dir/vendor/phpunit/php-file-iterator/src/Iterator.php on line 104

[IceShack]

@sebastianbergmann, any opinions?

[hugues-m]

Hi @IceShack , i'm having the same issue, have you found another workaround for this problem that doesn't involve code modification in phpunit libraries ?

[IceShack]

Unfortunately not, I just replaced the wildcards with the explicit directories

[hugues-m]

Ok, same here... Thanks !

[grzeg1]

@sebastianbergmann same issue here, we need this fix

[grzeg1]

fail scenario (this PR fixes the problem):

<testsuite name="part1">
       <directory>test/application/[a-m]*</directory>
       <exclude>test/application/model</exclude>
</testsuite>
        <testsuite name="part2">
        <directory>test/application/[n-z]*</directory>
</testsuite>

[cbeyer]

Same problem for me.
@grzeg1 have you tried this ?

<testsuite name="part1">
       <directory>test/application/[a-m]*</directory>
       <exclude>test/application/model*</exclude>
</testsuite>

[sebastianbergmann]

Superseded by #32.