Exclude is not considered if it's a parent of base path

[kamazee]

This seems to be the cause of sebastianbergmann/phpunit#2815.
When trying to make a single "exclude" relative, it strips base path from it which doesn't work if an "exclude" is a parent of base path, which (supposedly) must exclude all the contents of base path.
While #27 tries to address this issue, I'm not sure whether this would work on Windows so probably it needs another take.

[sebastianbergmann]

@kamazee Please send a new pull request that takes #37 into account. @kylekatarnls can probably help with debugging the issue.

[kamazee]

Will take a look when I have a moment!

[kamazee]

I reproduced and debugged the issue: it appeared to be an unfortunate combination of changes in 1.4.2 and 1.4.3: realpaths that are added in 1.4.3 sometimes return false, e.g. when an excluded directory doesn't exist. Such falses turn into an empty string that turns into current working directory down the line, and before 1.4.4 such excludes had been silently ignored. 1.4.4 stopped ignoring them, and that's why @kylekatarnls's tests appeared ignored.

@sebastianbergmann I'll fix this and revive my fix for exclusions but probably against master this time in order to target new possible new bugs introduced by the fix to newer code :)

[sebastianbergmann]

Any update on this? Thanks!

[kamazee]

Fix seems to be pretty simple, sorry for the long silence. Will do my best to address it over the weekend.

[kamazee]

@sebastianbergmann oh, I didn't notice another fix was proposed.

I tested the fix proposed by @slavcodev in #40 and it worked for both the test case added by me in sebastianbergmann/phpunit#2815 and #37 (ran tests of pug-symfony with a php-file-iterator fix from #40 -- @kylekatarnls, FYI).

It didn't work out of the box because master of php-file-iterator uses namespaces and none of projects that depend on php-file-iterator use namespaced names of the classes, so I had to add aliases manually just for the sake of making tests run. Maybe it's works to put aliases into both 1.4 and master, which, I guess it going to be 2.0, for forward and backward compatibility respectively (and drop them in 3.0, for example); @sebastianbergmann do you think it's something worth doing?

[stale]

This issue has been automatically marked as stale because it has not had activity within the last 60 days. It will be closed after 7 days if no further activity occurs. Thank you for your contributions.