Add enforce_min_max_values to datetime transformers #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
approved these changes
Nov 13, 2023
rdt/transformers/datetime.py
Outdated
| @@ -30,6 +30,9 @@ class UnixTimestampEncoder(BaseTransformer): | |||
| datetime_format (str): | |||
| The strftime to use for parsing time. For more information, see | |||
| https://docs.python.org/3/library/datetime.html#strftime-and-strptime-behavior. | |||
| enforce_min_max_values (bool): | |||
There was a problem hiding this comment.
Maybe we should add this as the last parameter. The main reason is that if someone runs scripts without using the key-word argument names, it might crash after this release since the 4th argument used to be a string and now it is a boolean with a different purpose. This isn't a huge deal though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86aynzc26
Resolve #740