Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enforce_min_max_values to datetime transformers #740

Closed
amontanez24 opened this issue Nov 9, 2023 · 0 comments · Fixed by #741
Closed

Add enforce_min_max_values to datetime transformers #740

amontanez24 opened this issue Nov 9, 2023 · 0 comments · Fixed by #741
Assignees
@R-Palazzo
Labels
feature request Request for a new feature
Milestone
1.9.0

Comments

@amontanez24
Copy link
Contributor

Problem Description

_As a user, I'd like my data to be within the same bounds as the original data since out of bounds data might not make sense logically (eg. someone is born on a day that hasn't happened yet).

Expected behavior

  • Add a enforce_min_max_values parameter to the UnixTimestampEncoder and OptimizedTimestampEncoder. This can be a boolean the same way as the FloatFormatter has it.
  • We can learn the min and max values in the fit.
  • We can clip the values back during reverse_transform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@R-Palazzo R-Palazzo

Labels
feature request Request for a new feature
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Add enforce_min_max_values to datetime transformers sdv-dev/RDT
2 participants
@amontanez24 @R-Palazzo